[PATCH] Two small errhint cleanups in PG19 code

Started by Baji Shaikabout 12 hours ago3 messageshackers
Jump to latest
#1Baji Shaik
baji.pgdev@gmail.com

Hi,

While exploring new features in PG19, I came across two unrelated
small errhint issues. Sending them as separate patches in one thread since
they touch
unrelated subsystems and can be reviewed/committed independently.

Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
The errhint in import_pg_statistic() reads:

Value of element "%s" must be type a null or a string.

The word "type" is a stray word that doesn't belong; the intent is
"must be a null or a string".

Patch 0002 -- Add missing period to online data checksums errhint
The errhint emitted when StartupXLOG() detects an interrupted
"enabling data checksums" run is missing a trailing period:

Data checksum processing must be manually restarted for
checksums to be enabled

Thanks,
Baji Shaik

Attachments:

0002-Add-missing-period-to-online-data-checksums-errhint.patchapplication/octet-stream; name=0002-Add-missing-period-to-online-data-checksums-errhint.patchDownload+1-2
0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patchapplication/octet-stream; name=0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patchDownload+1-2
#2Chao Li
li.evan.chao@gmail.com
In reply to: Baji Shaik (#1)
Re: [PATCH] Two small errhint cleanups in PG19 code

On May 25, 2026, at 10:38, Baji Shaik <baji.pgdev@gmail.com> wrote:

Hi,

While exploring new features in PG19, I came across two unrelated
small errhint issues. Sending them as separate patches in one thread since they touch
unrelated subsystems and can be reviewed/committed independently.

Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
The errhint in import_pg_statistic() reads:

Value of element "%s" must be type a null or a string.

The word "type" is a stray word that doesn't belong; the intent is
"must be a null or a string".

Agreed.

Patch 0002 -- Add missing period to online data checksums errhint
The errhint emitted when StartupXLOG() detects an interrupted
"enabling data checksums" run is missing a trailing period:

Data checksum processing must be manually restarted for
checksums to be enabled

Yes, a hint message should end with a period.

Thanks,
Baji Shaik
<0002-Add-missing-period-to-online-data-checksums-errhint.patch><0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch>

So, both changes look good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#3Michael Paquier
michael@paquier.xyz
In reply to: Chao Li (#2)
Re: [PATCH] Two small errhint cleanups in PG19 code

On Mon, May 25, 2026 at 01:38:26PM +0800, Chao Li wrote:

So, both changes look good to me.

Aye. One of them is on me but I'll just grab the second one while on
it. You forgot to update the regression test outputs, at quick
glance, but no need to send an updated patch.
--
Michael