Small fixes for CHECKPOINT FLUSH_UNLOGGED
Hi,
I just tested “Add FLUSH_UNLOGGED option to CHECKPOINT command”, and found no functional issue. I only noticed a couple of small issues.
1. Tab-completion for FLUSH_UNLOGGED misses its boolean value
FLUSH_UNLOGGED can take a boolean value, but tab completion does not suggest ON/OFF for it. For comparison, REPACK does:
```
evantest=# checkpoint (FLUSH_UNLOGGED o
evantest=# repack (concurrently O
OFF ON
```The fix just follows the existing code for REPACK. After the fix:
```
evantest=# checkpoint (flush_unlogged O
OFF ON
```
2. The CHECKPOINT doc still says “All data files will be flushed to disk”
After introducing FLUSH_UNLOGGED, CHECKPOINT by default no longer flushes dirty buffers of unlogged relations, but checkpoint.sgml still says “All data files will be flushed to disk.” That seems stale, so I updated the doc.
These are two small changes, but to make the patch easier to process, I split them into two commits.
Best reagards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Attachments:
v1-0002-doc-Clarify-CHECKPOINT-handling-of-unlogged-buffe.patchapplication/octet-stream; name=v1-0002-doc-Clarify-CHECKPOINT-handling-of-unlogged-buffe.patch; x-unix-mode=0644Download+4-3
v1-0001-psql-Complete-boolean-values-for-CHECKPOINT-FLUSH.patchapplication/octet-stream; name=v1-0001-psql-Complete-boolean-values-for-CHECKPOINT-FLUSH.patch; x-unix-mode=0644Download+2-1
On 25 May 2026, at 09:07, Chao Li <li.evan.chao@gmail.com> wrote:
These are two small changes, but to make the patch easier to process, I split them into two commits.
Thanks for testing and fixing. Both LGTM, will test a little and then apply
(perhaps with some editorializing on the docs patch).
--
Daniel Gustafsson