[PATCH] Fix typos in pqsignal.c comment

Started by Ewan Young4 months ago5 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t139781
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 26, 2026 at 11:53 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t139781_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t139781_1 && git checkout t139781_1

Patchset v1 (message #1) is on t139781_1

Jump to latest
#1Ewan Young
kdbase.hack@gmail.com

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

Attachments:

t139781_1
v1-0001-Fix-typos-in-pqsignal.c-comment.patchapplication/octet-stream; name=v1-0001-Fix-typos-in-pqsignal.c-comment.patchDownload+2-3
#2Ewan Young
kdbase.hack@gmail.com
In reply to: Ewan Young (#1)
Re: [PATCH] Fix typos in pqsignal.c comment

Hi,

For tracking, I've added this to the open commitfest:
https://commitfest.postgresql.org/patch/6871/

Regards,
Ewan Young

Show quoted text

On Fri, May 29, 2026 at 2:01 PM kdbase <kdbase.hack@gmail.com> wrote:

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

#3Chao Li
li.evan.chao@gmail.com
In reply to: Ewan Young (#2)
Re: [PATCH] Fix typos in pqsignal.c comment

On Jun 10, 2026, at 15:18, Ewan Young <kdbase.hack@gmail.com> wrote:

Hi,

For tracking, I've added this to the open commitfest:
https://commitfest.postgresql.org/patch/6871/

Regards,
Ewan Young

On Fri, May 29, 2026 at 2:01 PM kdbase <kdbase.hack@gmail.com> wrote:

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

I think this change will go into Michael's bag, so it doesn't need to be added to the CF.

FYI, Michael keeps collecting these kinds of tiny changes, such as typo fixes, and pushes them all together every couple of months.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#4Ewan Young
kdbase.hack@gmail.com
In reply to: Chao Li (#3)
Re: [PATCH] Fix typos in pqsignal.c comment

Thanks for letting me know — that's good to hear.

I'll withdraw the CommitFest entry then, and leave the patch here in
the thread for Michael to pick up whenever he next batches these
together.

Appreciate the pointer!

Best regards,
Ewan

Show quoted text

On Wed, Jun 10, 2026 at 3:28 PM Chao Li <li.evan.chao@gmail.com> wrote:

On Jun 10, 2026, at 15:18, Ewan Young <kdbase.hack@gmail.com> wrote:

Hi,

For tracking, I've added this to the open commitfest:
https://commitfest.postgresql.org/patch/6871/

Regards,
Ewan Young

On Fri, May 29, 2026 at 2:01 PM kdbase <kdbase.hack@gmail.com> wrote:

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

I think this change will go into Michael's bag, so it doesn't need to be added to the CF.

FYI, Michael keeps collecting these kinds of tiny changes, such as typo fixes, and pushes them all together every couple of months.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#5Michael Paquier
michael@paquier.xyz
In reply to: Ewan Young (#4)
Re: [PATCH] Fix typos in pqsignal.c comment

On Wed, Jun 10, 2026 at 03:32:28PM +0800, Ewan Young wrote:

I'll withdraw the CommitFest entry then, and leave the patch here in
the thread for Michael to pick up whenever he next batches these
together.

Picked up, thanks.
--
Michael