[PATCH] Fix typos in pqsignal.c comment

Started by Ewan Youngabout 2 months ago5 messageshackers
Jump to latest
#1Ewan Young
kdbase.hack@gmail.com

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

Attachments:

v1-0001-Fix-typos-in-pqsignal.c-comment.patchapplication/octet-stream; name=v1-0001-Fix-typos-in-pqsignal.c-comment.patchDownload+2-3
#2Ewan Young
kdbase.hack@gmail.com
In reply to: Ewan Young (#1)
Re: [PATCH] Fix typos in pqsignal.c comment

Hi,

For tracking, I've added this to the open commitfest:
https://commitfest.postgresql.org/patch/6871/

Regards,
Ewan Young

Show quoted text

On Fri, May 29, 2026 at 2:01 PM kdbase <kdbase.hack@gmail.com> wrote:

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

#3Chao Li
li.evan.chao@gmail.com
In reply to: Ewan Young (#2)
Re: [PATCH] Fix typos in pqsignal.c comment

On Jun 10, 2026, at 15:18, Ewan Young <kdbase.hack@gmail.com> wrote:

Hi,

For tracking, I've added this to the open commitfest:
https://commitfest.postgresql.org/patch/6871/

Regards,
Ewan Young

On Fri, May 29, 2026 at 2:01 PM kdbase <kdbase.hack@gmail.com> wrote:

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

I think this change will go into Michael's bag, so it doesn't need to be added to the CF.

FYI, Michael keeps collecting these kinds of tiny changes, such as typo fixes, and pushes them all together every couple of months.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#4Ewan Young
kdbase.hack@gmail.com
In reply to: Chao Li (#3)
Re: [PATCH] Fix typos in pqsignal.c comment

Thanks for letting me know — that's good to hear.

I'll withdraw the CommitFest entry then, and leave the patch here in
the thread for Michael to pick up whenever he next batches these
together.

Appreciate the pointer!

Best regards,
Ewan

Show quoted text

On Wed, Jun 10, 2026 at 3:28 PM Chao Li <li.evan.chao@gmail.com> wrote:

On Jun 10, 2026, at 15:18, Ewan Young <kdbase.hack@gmail.com> wrote:

Hi,

For tracking, I've added this to the open commitfest:
https://commitfest.postgresql.org/patch/6871/

Regards,
Ewan Young

On Fri, May 29, 2026 at 2:01 PM kdbase <kdbase.hack@gmail.com> wrote:

Hi hackers,

The attached patch fixes two typos in a comment in src/port/pqsignal.c:
- "this though wrapper handler" -> "this through wrapper handler"
- "as it it needs to take" -> "as it needs to take"

Comment-only change; no behavior change.

Regards,
Ewan Young

I think this change will go into Michael's bag, so it doesn't need to be added to the CF.

FYI, Michael keeps collecting these kinds of tiny changes, such as typo fixes, and pushes them all together every couple of months.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#5Michael Paquier
michael@paquier.xyz
In reply to: Ewan Young (#4)
Re: [PATCH] Fix typos in pqsignal.c comment

On Wed, Jun 10, 2026 at 03:32:28PM +0800, Ewan Young wrote:

I'll withdraw the CommitFest entry then, and leave the patch here in
the thread for Michael to pick up whenever he next batches these
together.

Picked up, thanks.
--
Michael