Improve errmsg for publication membership
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
This thread has been committed, so CI has stopped here. Anything below is the last result it produced.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t139822psql -h localhost -U postgresBuilt from patchset v1 (message #1), August 08, 2026 at 03:09 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t139822_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t139822_1 && git checkout t139822_1Patchset v1 (message #1) is on t139822_1
Here is a patch to reword 2 publication error messages:
BEFORE/AFTER
"relation \"%s\" is already member of publication \"%s\"",
"relation \"%s\" is already a member of publication \"%s\"",
BEFORE/AFTER
"schema \"%s\" is already member of publication \"%s\"",
"schema \"%s\" is already a member of publication \"%s\"",
~~~
All other 'member of' error messages in PostgreSQL source are using
correct grammar ('a member of'), so IMO these should do likewise.
PSA v1.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Jun 3, 2026 at 1:10 PM Peter Smith <smithpb2250@gmail.com> wrote:
Here is a patch to reword 2 publication error messages:
BEFORE/AFTER
"relation \"%s\" is already member of publication \"%s\"",
"relation \"%s\" is already a member of publication \"%s\"",BEFORE/AFTER
"schema \"%s\" is already member of publication \"%s\"",
"schema \"%s\" is already a member of publication \"%s\"",~~~
All other 'member of' error messages in PostgreSQL source are using
correct grammar ('a member of'), so IMO these should do likewise.PSA v1.
Thanks. Patch applies cleanly on master, the wording fix matches all other
'member of' messages in the tree, and make check passes (245/245). LGTM.
Regards,
Ewan
Show quoted text
======
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Jun 3, 2026 at 11:35 AM Ewan Young <kdbase.hack@gmail.com> wrote:
On Wed, Jun 3, 2026 at 1:10 PM Peter Smith <smithpb2250@gmail.com> wrote:
Here is a patch to reword 2 publication error messages:
BEFORE/AFTER
"relation \"%s\" is already member of publication \"%s\"",
"relation \"%s\" is already a member of publication \"%s\"",BEFORE/AFTER
"schema \"%s\" is already member of publication \"%s\"",
"schema \"%s\" is already a member of publication \"%s\"",~~~
All other 'member of' error messages in PostgreSQL source are using
correct grammar ('a member of'), so IMO these should do likewise.PSA v1.
Thanks. Patch applies cleanly on master, the wording fix matches all other
'member of' messages in the tree, and make check passes (245/245). LGTM.
LGTM as well. I think it is a minor inconsistency and we should fix it
only in HEAD. If so, we can probably wait for the PG20 branch to open
as this is not newly introduced in PG19.
--
With Regards,
Amit Kapila.
On Mon, Jun 8, 2026 at 7:24 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Wed, Jun 3, 2026 at 11:35 AM Ewan Young <kdbase.hack@gmail.com> wrote:
On Wed, Jun 3, 2026 at 1:10 PM Peter Smith <smithpb2250@gmail.com> wrote:
Here is a patch to reword 2 publication error messages:
BEFORE/AFTER
"relation \"%s\" is already member of publication \"%s\"",
"relation \"%s\" is already a member of publication \"%s\"",BEFORE/AFTER
"schema \"%s\" is already member of publication \"%s\"",
"schema \"%s\" is already a member of publication \"%s\"",~~~
All other 'member of' error messages in PostgreSQL source are using
correct grammar ('a member of'), so IMO these should do likewise.PSA v1.
Thanks. Patch applies cleanly on master, the wording fix matches all other
'member of' messages in the tree, and make check passes (245/245). LGTM.LGTM as well. I think it is a minor inconsistency and we should fix it
only in HEAD. If so, we can probably wait for the PG20 branch to open
as this is not newly introduced in PG19.
I also think it only needs to be fixed in HEAD. And, the PG20 branch
started ages ago, so AFAIK there are no blockers for this patch
anymore.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
On 10 Aug 2026, at 08:15, Peter Smith <smithpb2250@gmail.com> wrote:
I also think it only needs to be fixed in HEAD. And, the PG20 branch
started ages ago, so AFAIK there are no blockers for this patch
anymore.
Maybe not ages ago (~6 weeks) but agreed that this can go master only, patch
pushed.
--
Daniel Gustafsson
On Mon, Aug 10, 2026 at 4:52 PM Daniel Gustafsson <daniel@yesql.se> wrote:
On 10 Aug 2026, at 08:15, Peter Smith <smithpb2250@gmail.com> wrote:
I also think it only needs to be fixed in HEAD. And, the PG20 branch
started ages ago, so AFAIK there are no blockers for this patch
anymore.Maybe not ages ago (~6 weeks) but agreed that this can go master only, patch
pushed.
Thanks for pushing!
I've marked the CF entry as "committed".
======
Kind Regards,
Peter Smith.
Fujitsu Australia