Use streaming read I/O when enabling data checksums online

Started by cca550720 days ago3 messageshackers
Jump to latest
#1cca5507
cca5507@qq.com

Hi hackers,

Attach a simple patch for $subject. I think we prefer streaming IO instead of
ReadBufferExtended(). Do I miss something?

--
Regards,
ChangAo Chen

Attachments:

v1-0001-Use-streaming-read-I-O-when-enabling-data-checksu.patchapplication/octet-stream; charset=utf-8; name=v1-0001-Use-streaming-read-I-O-when-enabling-data-checksu.patchDownload+32-4
#2Daniel Gustafsson
daniel@yesql.se
In reply to: cca5507 (#1)
Re: Use streaming read I/O when enabling data checksums online

On 3 Jun 2026, at 13:10, cca5507 <cca5507@qq.com> wrote:

Attach a simple patch for $subject. I think we prefer streaming IO instead of
ReadBufferExtended(). Do I miss something?

Thanks! This code was written well before read streams existed, and recent
work was focused on correctness of operation, that's the main reason it's using
ReadBufferExtended still. We probably want do something like this once the
tree opens up after the v19 feature freeze.

--
Daniel Gustafsson

#3cca5507
cca5507@qq.com
In reply to: Daniel Gustafsson (#2)
Re: Use streaming read I/O when enabling data checksums online

 Attach a simple patch for $subject. I think we prefer streaming IO instead of
 ReadBufferExtended(). Do I miss something?

Thanks!  This code was written well before read streams existed, and recent
work was focused on correctness of operation, that's the main reason it's using
ReadBufferExtended still.  We probably want do something like this once the
tree opens up after the v19 feature freeze.

Get it! I created a CF entry for this:

https://commitfest.postgresql.org/patch/6841/

--
Regards,
ChangAo Chen