Fix missing semicolon in pl_gram.y for option_value rule
The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was
missing a terminating semicolon, which is inconsistent with the style
used by other rules in the file. While Bison does not require
semicolons to terminate grammar rules, adding one here improves
consistency and readability.
Attachments:
v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patchapplication/octet-stream; name=v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patchDownload+1-1
Hello，
The "decl_is_for" syntax block has the same issue.
It can be modified together.
------------------ 原始邮件 ------------------
发件人: "shaobo zhang" <zshaoo224@gmail.com>;
发送时间: 2026年6月5日(星期五) 下午3:01
收件人: "pgsql-hackers"<pgsql-hackers@lists.postgresql.org>;
主题: Fix missing semicolon in pl_gram.y for option_value rule
The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was
missing a terminating semicolon, which is inconsistent with the style
used by other rules in the file. While Bison does not require
semicolons to terminate grammar rules, adding one here improves
consistency and readability.
On Jun 5, 2026, at 15:01, shaobo zhang <zshaoo224@gmail.com> wrote:
The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was
missing a terminating semicolon, which is inconsistent with the style
used by other rules in the file. While Bison does not require
semicolons to terminate grammar rules, adding one here improves
consistency and readability.
<v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patch>
I would not call this a “fix” as it doesn’t fix anything not working today. It is actually a grammar-style cleanup. Since the code being changed is 12 years old, I think this patch is a candidate for v20.
Would you please add it to the CommitFest so that it can be noticed after v20 opens?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Hi,
Thank you for the review!
You're right — this is a grammar-style cleanup rather than a fix, since
the existing code works fine without the semicolon. I've reworded the
commit message accordingly to make that clear, and attached it as v2.
I'll add it to the CommitFest as you suggested so it can be picked up
after v20 opens.
Best regards,
shaobo zhang
Chao Li <li.evan.chao@gmail.com> 于2026年6月9日周二 13:52写道：
Show quoted text
On Jun 5, 2026, at 15:01, shaobo zhang <zshaoo224@gmail.com> wrote:
The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was
missing a terminating semicolon, which is inconsistent with the style
used by other rules in the file. While Bison does not require
semicolons to terminate grammar rules, adding one here improves
consistency and readability.
<v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patch>I would not call this a “fix” as it doesn’t fix anything not working today. It is actually a grammar-style cleanup. Since the code being changed is 12 years old, I think this patch is a candidate for v20.
Would you please add it to the CommitFest so that it can be noticed after v20 opens?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Oops, I forgot to attach the patch in my previous reply. Attaching v2 now.
Best regards,
shaobo zhang
shaobo zhang <zshaoo224@gmail.com> 于2026年6月9日周二 14:41写道：
Show quoted text
Hi,
Thank you for the review!
You're right — this is a grammar-style cleanup rather than a fix, since
the existing code works fine without the semicolon. I've reworded the
commit message accordingly to make that clear, and attached it as v2.I'll add it to the CommitFest as you suggested so it can be picked up
after v20 opens.Best regards,
shaobo zhangChao Li <li.evan.chao@gmail.com> 于2026年6月9日周二 13:52写道：
On Jun 5, 2026, at 15:01, shaobo zhang <zshaoo224@gmail.com> wrote:
The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was
missing a terminating semicolon, which is inconsistent with the style
used by other rules in the file. While Bison does not require
semicolons to terminate grammar rules, adding one here improves
consistency and readability.
<v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patch>I would not call this a “fix” as it doesn’t fix anything not working today. It is actually a grammar-style cleanup. Since the code being changed is 12 years old, I think this patch is a candidate for v20.
Would you please add it to the CommitFest so that it can be noticed after v20 opens?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Attachments:
v2-0001-plpgsql-Add-missing-terminating-semicolon-to-opti.patchapplication/octet-stream; name=v2-0001-plpgsql-Add-missing-terminating-semicolon-to-opti.patchDownload+1-1
On Tue, Jun 09, 2026 at 12:51:47PM +0800, Chao Li wrote:
I would not call this a “fix” as it doesn’t fix anything not working
today. It is actually a grammar-style cleanup. Since the code being
changed is 12 years old, I think this patch is a candidate for v20.
Why do we even need to care about that?
--
Michael
On Tue, Jun 09, 2026 at 12:51:47PM +0800, Chao Li wrote:
I would not call this a “fix” as it doesn’t fix anything not working
today. It is actually a grammar-style cleanup. Since the code being
changed is 12 years old, I think this patch is a candidate for v20.Why do we even need to care about that?
--
Michael
Agreed, it's purely cosmetic. If there's no interest in this cleanup,
I'm fine to withdraw it. Thanks both for looking.