Re: pgsql: doc: Clarify OAuth validator authn_id logging
Op 6/6/26 om 00:22 schreef Daniel Gustafsson:
doc: Clarify OAuth validator authn_id logging
Author: Chao Li <lic@highgo.com>
Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
Reported-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: /messages/by-id/0281836A-F5FF-41A5-9EE1-656C1FAAC6B2@gmail.comBranch
------
masterDetails
-------
https://git.postgresql.org/pg/commitdiff/4cb2e2fe0aa8251bef8c2e2351cd5a062c105c0aModified Files
--------------
doc/src/sgml/oauth-validators.sgml | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
Hi,
In doc/src/sgml/oauth-validators.sgml, and if I understand this text
correctly (always a big if), then:
"If the validator returns true and set result->authn_id then"
should be:
"If the validator returns true and sets result->authn_id then"
(i.e., set -> sets)
(added Michael in CC as he seems to collect these minimal patches, to be
committed later as a group)
Thanks,
Erik
Import Notes
Reply to msg id not found: E1wVcvV-001Fkp-2Z@gemulon.postgresql.orgReference msg id not found: E1wVcvV-001Fkp-2Z@gemulon.postgresql.org
On Sat, Jun 06, 2026 at 02:36:24PM +0200, Erik Rijkers wrote:
In doc/src/sgml/oauth-validators.sgml, and if I understand this text
correctly (always a big if), then:"If the validator returns true and set result->authn_id then"
should be:
"If the validator returns true and sets result->authn_id then"
(i.e., set -> sets)(added Michael in CC as he seems to collect these minimal patches, to be
committed later as a group)
In auth-oauth.c, there is a validate() path setting the authn_id, so
your suggestion sounds right. I've grabbed that for later. My branch
can always be overwritten by somebody else's commit preference, of
course, so if you feel that this should be fixed separately, feel free
to go ahead.
--
Michael