Fix comment in report_sequence_errors()
Hi
I noticed an incorrect comment in report_sequence_errors() in sequencesync.c.
The function comment describes case (c) as:
```
* c) missing sequences on the subscriber
```
However, the actual warning message emitted and the logic that
populates missing_seqs_idx both refer to sequences that are missing on
the publisher side, not the subscriber.
The fix is to replace "subscriber" with "publisher" in that comment line.
Thanks
Imran Zaheer
Attachments:
v1-0001-Fix-wrong-comment-in-report_sequence_errors.patchtext/x-patch; charset=US-ASCII; name=v1-0001-Fix-wrong-comment-in-report_sequence_errors.patchDownload+1-2
On Sun, Jun 07, 2026 at 07:35:05PM +0500, Imran Zaheer wrote:
However, the actual warning message emitted and the logic that
populates missing_seqs_idx both refer to sequences that are missing on
the publisher side, not the subscriber.The fix is to replace "subscriber" with "publisher" in that comment line.
The first comment could also make clear the fact that we care about
inconsistent definitions on the subscriber side. Grabbed these,
thanks.
--
Michael
On Mon, Jun 8, 2026 at 5:58 AM Michael Paquier <michael@paquier.xyz> wrote:
On Sun, Jun 07, 2026 at 07:35:05PM +0500, Imran Zaheer wrote:
However, the actual warning message emitted and the logic that
populates missing_seqs_idx both refer to sequences that are missing on
the publisher side, not the subscriber.The fix is to replace "subscriber" with "publisher" in that comment line.
The first comment could also make clear the fact that we care about
inconsistent definitions on the subscriber side. Grabbed these,
thanks.
The patch looks good to me. IIUC, you are planning to commit this one
along with some other typo/minor fixes, right?
--
With Regards,
Amit Kapila.