pgsql: timestamptz_trunc() should only recalculate the timezone when

Started by Tom Laneover 21 years ago3 messageshackers
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Log Message:
-----------
timestamptz_trunc() should only recalculate the timezone when truncating
to DAY precision or coarser; leave the timezone alone when precision is
HOUR or less. This avoids surprises for inputs near a DST transition
time, as per example from Matthew Gabeler-Lee. (The only reason we
recalculate at all is so that outputs that are supposed to represent
days will come out as local midnight, and that's not relevant for sub-day
precision.)

Modified Files:
--------------
pgsql/src/backend/utils/adt:
timestamp.c (r1.113 -> r1.114)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/timestamp.c.diff?r1=1.113&r2=1.114)

#2Devrim GÜNDÜZ
devrim@gunduz.org
In reply to: Tom Lane (#1)
Re: [COMMITTERS] pgsql: timestamptz_trunc() should only recalculate

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I got an error in make check now, in horology test:

http://postgresql.gunduz.org/regression.diffs

Is it related to this commit?

Regards, Devrim
On Mon, 1 Nov 2004, Tom Lane wrote:

Log Message:
-----------
timestamptz_trunc() should only recalculate the timezone when truncating
to DAY precision or coarser; leave the timezone alone when precision is
HOUR or less. This avoids surprises for inputs near a DST transition
time, as per example from Matthew Gabeler-Lee. (The only reason we
recalculate at all is so that outputs that are supposed to represent
days will come out as local midnight, and that's not relevant for sub-day
precision.)

Modified Files:
--------------
pgsql/src/backend/utils/adt:
timestamp.c (r1.113 -> r1.114)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/timestamp.c.diff?r1=1.113&r2=1.114)

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

- --
Devrim GUNDUZ
devrim~gunduz.org devrim.gunduz~linux.org.tr
http://www.tdmsoft.com
http://www.gunduz.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFBhrpMtl86P3SPfQ4RAvtXAKCs7zWA3n8crbd5VsToKoTobHqtEQCdEw5y
mU92XW7xTLm3iC3L+jq0idA=
=Rm7E
-----END PGP SIGNATURE-----

#3Devrim GÜNDÜZ
devrim@gunduz.org
In reply to: Devrim GÜNDÜZ (#2)
Re: [COMMITTERS] pgsql: timestamptz_trunc() should only

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On Tue, 2 Nov 2004, Devrim GUNDUZ wrote:

I got an error in make check now, in horology test:

http://postgresql.gunduz.org/regression.diffs

Is it related to this commit?

Ok, it seems no (tested with revision 1.113 for double-check). I've just
read the recent discussion on -hackers.

Regards,
- --
Devrim GUNDUZ
devrim~gunduz.org devrim.gunduz~linux.org.tr
http://www.tdmsoft.com
http://www.gunduz.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFBhsAmtl86P3SPfQ4RAkipAKDaxAegnb7yv00devyxpyU0c9GGMwCeKD/w
gxkgKxcnE+A7tFaZ0i+oVsc=
=3oIT
-----END PGP SIGNATURE-----