Windows default to localhost is in the wrong place

Started by Tom Laneabout 21 years ago3 messages
#1Tom Lane
tgl@sss.pgh.pa.us

Isn't this fix in the wrong place?

2004-03-23 22:10 momjian

* src/bin/psql/startup.c: >>Also, what is the default connection
mode of psql? It should probably be

equivalent to "-h localhost", shouldn't it?

Now that is something I had not thought of. Seems we can assume a

Win32

psql can never use unix domain sockets, so defaulting that to

localhost

is a good solution too.

Andrew Dunstan

ISTM that libpq itself ought to default to localhost, rather than
failing, on machines that don't have Unix sockets.

regards, tom lane

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#1)
Re: Windows default to localhost is in the wrong place

Tom Lane wrote:

Isn't this fix in the wrong place?

2004-03-23 22:10 momjian

* src/bin/psql/startup.c: >>Also, what is the default connection
mode of psql? It should probably be

equivalent to "-h localhost", shouldn't it?

Now that is something I had not thought of. Seems we can assume a

Win32

psql can never use unix domain sockets, so defaulting that to

localhost

is a good solution too.

Andrew Dunstan

ISTM that libpq itself ought to default to localhost, rather than
failing, on machines that don't have Unix sockets.

So then it would be picked up by pg_dump, createdb etc., plus third
party clients? Not a bad idea. Are you going to fix it for 8.0?

cheers

andrew

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#2)
Re: Windows default to localhost is in the wrong place

Andrew Dunstan <andrew@dunslane.net> writes:

Tom Lane wrote:

ISTM that libpq itself ought to default to localhost, rather than
failing, on machines that don't have Unix sockets.

So then it would be picked up by pg_dump, createdb etc., plus third
party clients? Not a bad idea. Are you going to fix it for 8.0?

If I don't hear any objections in the next few hours ...

regards, tom lane