pgsql/src/interfaces/python GNUmakefile

Started by Peter Eisentrautover 24 years ago5 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

CVSROOT: /cvsroot
Module name: pgsql
Changes by: petere@postgresql.org 01/12/13 13:39:04

Modified files:
src/interfaces/python: GNUmakefile

Log message:
revert last change

#2D'Arcy J.M. Cain
darcy@druid.net
In reply to: Peter Eisentraut (#1)
Re: pgsql/src/interfaces/python GNUmakefile

Thus spake petere@postgresql.org

CVSROOT: /cvsroot
Module name: pgsql
Changes by: petere@postgresql.org 01/12/13 13:39:04

Modified files:
src/interfaces/python: GNUmakefile

Log message:
revert last change

Can I ask why please? These changes were discussed on list and I agreed
to wait for the release before submitting them.

Given that PyGreSQL was supposed to be somewhat autonomous I think that
this should at least have had a little more explanation.

-- 
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 425 1212     (DoD#0082)    (eNTP)   |  what's for dinner.
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: D'Arcy J.M. Cain (#2)
Re: pgsql/src/interfaces/python GNUmakefile

darcy@druid.net (D'Arcy J.M. Cain) writes:

Can I ask why please?

That change broke the build for the case of building outside the source
tree; cf recent complaint from Trond.

These changes were discussed on list and I agreed
to wait for the release before submitting them.

That's what I thought had been agreed to, also. So why *didn't* you
wait till after the release (ie, till after 7.2/7.3 branch has been
made)?

regards, tom lane

#4D'Arcy J.M. Cain
darcy@druid.net
In reply to: Tom Lane (#3)
Re: pgsql/src/interfaces/python GNUmakefile

Thus spake Tom Lane

darcy@druid.net (D'Arcy J.M. Cain) writes:

Can I ask why please?

That change broke the build for the case of building outside the source
tree; cf recent complaint from Trond.

Must have missed that. I am reviewing it in the archive now.

These changes were discussed on list and I agreed
to wait for the release before submitting them.

That's what I thought had been agreed to, also. So why *didn't* you
wait till after the release (ie, till after 7.2/7.3 branch has been
made)?

Sorry, I got confused. I thought that the release was already done. I
think I got mixed up with 7.1.3 showing up in the NetBSD packages. I do
apologize. When is the branch expected?

-- 
D'Arcy J.M. Cain <darcy@{druid|vex}.net>   |  Democracy is three wolves
http://www.druid.net/darcy/                |  and a sheep voting on
+1 416 425 1212     (DoD#0082)    (eNTP)   |  what's for dinner.
#5Peter Eisentraut
peter_e@gmx.net
In reply to: D'Arcy J.M. Cain (#2)
Re: pgsql/src/interfaces/python GNUmakefile

D'Arcy J.M. Cain writes:

Log message:
revert last change

Can I ask why please? These changes were discussed on list and I agreed
to wait for the release before submitting them.

Given that PyGreSQL was supposed to be somewhat autonomous I think that
this should at least have had a little more explanation.

1. The changes broke the build.

2. Waiting for release means waiting for release. I didn't see a release
yet.

3. It was *not* agreed to wait for the release. You did not reply to my
objections to the patch. As I explained, implementing the python
compilation this way is broken.

4. PyGresSQL is not autonomous. I think you shouldn't have moved the
development into the main tree if you thought so.

--
Peter Eisentraut peter_e@gmx.net