pgsql-server/src/pl/plpgsql/src scan.l

Started by Bruce Momjianalmost 24 years ago4 messagescomitters
Jump to latest
#1Bruce Momjian
bruce@momjian.us

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian@postgresql.org 02/08/03 23:59:09

Modified files:
src/pl/plpgsql/src: scan.l

Log message:
I send a simple patch for PL/pgSQL parser which allow now to use
whitespaces in identifers of any kind(table names,attribute
names,variables ...) in Pl/pgSQL procedural language.Explicit definition
of bug can be found in Re: [HACKERS] Bug of PL/pgSQL parser

TODO item completed:

o -Fix PL/PgSQL to handle quoted mixed-case identifiers

eutm

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: pgsql-server/src/pl/plpgsql/src scan.l

momjian@postgresql.org (Bruce Momjian - CVS) writes:

I send a simple patch for PL/pgSQL parser which allow now to use
whitespaces in identifers of any kind(table names,attribute
names,variables ...) in Pl/pgSQL procedural language.Explicit definition
of bug can be found in Re: [HACKERS] Bug of PL/pgSQL parser

I feel sure I pointed out that this patch is wrong.

regards, tom lane

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql-server/src/pl/plpgsql/src scan.l

Tom Lane wrote:

momjian@postgresql.org (Bruce Momjian - CVS) writes:

I send a simple patch for PL/pgSQL parser which allow now to use
whitespaces in identifers of any kind(table names,attribute
names,variables ...) in Pl/pgSQL procedural language.Explicit definition
of bug can be found in Re: [HACKERS] Bug of PL/pgSQL parser

I feel sure I pointed out that this patch is wrong.

Yea, I was already researching this. I can't find your comment and I
thought this was a _newer_ version of the patch. Can't find your
comment in the archives. Let me attach the patch. Is it wrong?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Attachments:

/bjm/2text/plainDownload+34-3
#4Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql-server/src/pl/plpgsql/src scan.l

Tom Lane wrote:

momjian@postgresql.org (Bruce Momjian - CVS) writes:

I send a simple patch for PL/pgSQL parser which allow now to use
whitespaces in identifers of any kind(table names,attribute
names,variables ...) in Pl/pgSQL procedural language.Explicit definition
of bug can be found in Re: [HACKERS] Bug of PL/pgSQL parser

I feel sure I pointed out that this patch is wrong.

OK, I figured it out. The submitter sent the same patch on the 23rd and
30th with different text. I assumed the 30th had the fix but it seems
he just sent the same patch. If someone wants to hack it, it is at:

http://fts.postgresql.org/db/mw/msg.html?mid=1076915

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026