pgsql-server/ oc/src/sgml/rules.sgml rc/backen ...

Started by Tom Lanealmost 24 years ago2 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@postgresql.org 02/10/19 15:00:47

Modified files:
doc/src/sgml : rules.sgml
src/backend/rewrite: rewriteHandler.c
src/test/regress/expected: rules.out
src/test/regress/sql: rules.sql

Log message:
Fix rewrite code so that rules are in fact executed in order by name,
rather than being reordered according to INSTEAD attribute for
implementation convenience.
Also, increase compiled-in recursion depth limit from 10 to 100 rewrite
cycles. 10 seems pretty marginal for situations where multiple rules
exist for the same query. There was a complaint about this recently,
so I'm going to bump it up. (Perhaps we should make the limit a GUC
parameter, but that's too close to being a new feature to do in beta.)

#2Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#1)
Re: pgsql-server/ oc/src/sgml/rules.sgml rc/backen ...

]Tom Lane wrote:

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@postgresql.org 02/10/19 15:00:47

Modified files:
doc/src/sgml : rules.sgml
src/backend/rewrite: rewriteHandler.c
src/test/regress/expected: rules.out
src/test/regress/sql: rules.sql

Log message:
Fix rewrite code so that rules are in fact executed in order by name,
rather than being reordered according to INSTEAD attribute for
implementation convenience.
Also, increase compiled-in recursion depth limit from 10 to 100 rewrite
cycles. 10 seems pretty marginal for situations where multiple rules
exist for the same query. There was a complaint about this recently,
so I'm going to bump it up. (Perhaps we should make the limit a GUC
parameter, but that's too close to being a new feature to do in beta.)

Added to TODO:

o Add GUC parameter to control the maximum number of rewrite cycles

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073