pgsql-server/src test/regress/expected/join.ou ...

Started by Bruce Momjianover 23 years ago7 messagescomitters
Jump to latest
#1Bruce Momjian
bruce@momjian.us

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian@postgresql.org 02/10/29 20:15:51

Modified files:
src/test/regress/expected: join.out
src/test/regress/sql: join.sql
Removed files:
src/utils : Makefile dllinit.c

Log message:
Remove /src/utils. Is final cleanup of getopt.c resurection.

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#1)
Re: pgsql-server/src test/regress/expected/join.ou ...

Don't we still need the dllinit.c file? What does this have to do with
getopt.c and the join test?

Bruce Momjian - CVS writes:

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian@postgresql.org 02/10/29 20:15:51

Modified files:
src/test/regress/expected: join.out
src/test/regress/sql: join.sql
Removed files:
src/utils : Makefile dllinit.c

Log message:
Remove /src/utils. Is final cleanup of getopt.c resurection.

--
Peter Eisentraut peter_e@gmx.net

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#2)
Re: pgsql-server/src test/regress/expected/join.ou ...

Peter Eisentraut <peter_e@gmx.net> writes:

Don't we still need the dllinit.c file?

Sure looks like it to me: see src/makefiles/Makefile.win. Bruce,
please put that back, and the Makefile for it too.

regards, tom lane

Show quoted text

Bruce Momjian - CVS writes:

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: momjian@postgresql.org 02/10/29 20:15:51

Modified files:
src/test/regress/expected: join.out
src/test/regress/sql: join.sql
Removed files:
src/utils : Makefile dllinit.c

Log message:
Remove /src/utils. Is final cleanup of getopt.c resurection.

--
Peter Eisentraut peter_e@gmx.net

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

#4Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#3)
Re: pgsql-server/src test/regress/expected/join.ou ...

Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Don't we still need the dllinit.c file?

Sure looks like it to me: see src/makefiles/Makefile.win. Bruce,
please put that back, and the Makefile for it too.

I removed those files a long time ago:

revision 1.10
date: 2002/07/16 05:46:36; author: momjian; state: dead; lines: +0 -0
Move few remaining src/utils files to backend/port so everything is in
one place. Everything may be moved to src/utils eventually.

I re-added /src/utils just so I could get getopt.c back. The removal
was just re-removing /utils. However, I now don't understand these
commits:

revision 1.12
date: 2002/10/30 01:15:51; author: momjian; state: dead; lines: +0 -0
Remove /src/utils. Is final cleanup of getopt.c resurection.
----------------------------
revision 1.11
date: 2002/07/27 20:10:05; author: petere; state: Exp; lines: +0 -0
Assemble portability modules into libpgport library.
Some makefile simplifications.

The top was was me removing the files, but I don't understand 1.11. We
peter readding the files? Why didn't I have a /utils directory here?
Why do we have successful cygin builds? I am confused.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#5Bruce Momjian
bruce@momjian.us
In reply to: Bruce Momjian (#4)
Re: pgsql-server/src test/regress/expected/join.ou ...

I also need to know how to bring back a missing file. The last time I
did a cvs diff and created the file that way, but it seems there must be
an easier way.

---------------------------------------------------------------------------

Bruce Momjian wrote:

Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Don't we still need the dllinit.c file?

Sure looks like it to me: see src/makefiles/Makefile.win. Bruce,
please put that back, and the Makefile for it too.

I removed those files a long time ago:

revision 1.10
date: 2002/07/16 05:46:36; author: momjian; state: dead; lines: +0 -0
Move few remaining src/utils files to backend/port so everything is in
one place. Everything may be moved to src/utils eventually.

I re-added /src/utils just so I could get getopt.c back. The removal
was just re-removing /utils. However, I now don't understand these
commits:

revision 1.12
date: 2002/10/30 01:15:51; author: momjian; state: dead; lines: +0 -0
Remove /src/utils. Is final cleanup of getopt.c resurection.
----------------------------
revision 1.11
date: 2002/07/27 20:10:05; author: petere; state: Exp; lines: +0 -0
Assemble portability modules into libpgport library.
Some makefile simplifications.

The top was was me removing the files, but I don't understand 1.11. We
peter readding the files? Why didn't I have a /utils directory here?
Why do we have successful cygin builds? I am confused.

-- 
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 359-1001
+  If your life is a hard drive,     |  13 Roberts Road
+  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#4)
Re: pgsql-server/src test/regress/expected/join.ou ...

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Why do we have successful cygin builds?

I don't think that we do at this point :-(. Has anyone tried it in the
last three days (ie, since you removed dllinit.c)?

regards, tom lane

#7Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#6)
Re: pgsql-server/src test/regress/expected/join.ou ...

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Why do we have successful cygin builds?

I don't think that we do at this point :-(. Has anyone tried it in the
last three days (ie, since you removed dllinit.c)?

OK, I think I got it back. I ended up adding a zero-length file, cvs
committing, then doing a CVS diff of the empty file and the file before
removal, applied that patch, and committed that.

Not sure how I got confused. I though there was no /utils directory
when I started the getopt.c resurection, but actually I may have gotten
confused over that.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073