pgsql-server/src backend/catalog/dependency.c ...

Started by Tom Laneover 23 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@postgresql.org 02/11/30 16:25:09

Modified files:
src/backend/catalog: dependency.c
src/backend/executor: execQual.c
src/backend/optimizer/plan: setrefs.c
src/backend/optimizer/util: clauses.c
src/backend/parser: parse_expr.c
src/include/nodes: primnodes.h
src/pl/plpgsql/src: pl_exec.c

Log message:
Code review for IS DISTINCT FROM patch. Fix incorrect constant-folding
logic, dissuade planner from thinking that 'x IS DISTINCT FROM 42' may
be optimized into 'x = 42' (!!), cause dependency on = operator to be
recorded correctly, minor other improvements.

#2Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Tom Lane (#1)
Re: pgsql-server/src backend/catalog/dependency.c ...

Log message:
Code review for IS DISTINCT FROM patch. Fix incorrect constant-folding
logic, dissuade planner from thinking that 'x IS DISTINCT FROM 42' may
be optimized into 'x = 42' (!!), cause dependency on = operator to be
recorded correctly, minor other improvements.

Should that be back patched for 7.3.1?

Chris

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christopher Kings-Lynne (#2)
Re: pgsql-server/src backend/catalog/dependency.c ...

"Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:

Code review for IS DISTINCT FROM patch.

Should that be back patched for 7.3.1?

Given the rather complete lack of documentation for IS DISTINCT FROM
in 7.3, I'm not too concerned about anyone trying to use it ;-)

regards, tom lane