new return value of PQfsize

Started by Edmund Merglover 27 years ago2 messages
#1Edmund Mergl
E.Mergl@bawue.de

Hi,

the libpq-function PQfsize() now returns
int instead of short. It looks like, that
this needs some adaption in the backend,
because now the size of a variable length
field is returned as 65535 instead of -1.

Edmund
--
Edmund Mergl mailto:E.Mergl@bawue.de
Im Haldenhau 9 http://www.bawue.de/~mergl
70565 Stuttgart fon: +49 711 747503
Germany

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Edmund Mergl (#1)
Re: [HACKERS] new return value of PQfsize

Edmund Mergl <E.Mergl@bawue.de> writes:

the libpq-function PQfsize() now returns int instead of
short. It looks like, that this needs some adaption in the
backend, because now the size of a variable length field is
returned as 65535 instead of -1.

Oops. That's libpq's bug, not the backend's.

I thought that the rearrangement of libpq's interface
would be a good time to hide the fact that field sizes are
currently restricted to short --- which was visible in the
return type of PQfsize, and nowhere else in libpq's API.

But I guess I forgot to ensure that sign extension would happen
correctly :-(. Will fix.

regards, tom lane