pgsql-server/src/bin/pg_dump pg_dumpall.c

Started by Tom Laneover 23 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@postgresql.org 03/03/14 17:45:50

Modified files:
src/bin/pg_dump: pg_dumpall.c

Log message:
pg_dumpall failed on groups having no members. Per report from
Nick Eskelinen.

#2Neil Conway
neilc@samurai.com
In reply to: Tom Lane (#1)
Re: pgsql-server/src/bin/pg_dump pg_dumpall.c

On Fri, 2003-03-14 at 17:45, Tom Lane wrote:

pg_dumpall failed on groups having no members.

Having a regression testing suite for pg_dump would be useful, IMHO.

But until we have that, perhaps it would be a good idea to add corner
cases like these to the normal regression tests (as it's easy to test
pg_dump by running 'make installcheck', then dumping and reloading the
regression DB).

Cheers,

Neil

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Neil Conway (#2)
Re: pgsql-server/src/bin/pg_dump pg_dumpall.c

Neil Conway <neilc@samurai.com> writes:

But until we have that, perhaps it would be a good idea to add corner
cases like these to the normal regression tests (as it's easy to test
pg_dump by running 'make installcheck', then dumping and reloading the
regression DB).

It's only recently that that actually worked ... 7.3 I think :-(.
But yeah, regression tests for pg_dump would be a fine idea.

I seem to recall the Great Bridge folks had done some work towards that
(but it's probably unrecoverable now, so never mind...)

regards, tom lane