pgsql-server/src/backend/utils/adt network.c

Started by Tom Laneover 22 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@svr1.postgresql.org 03/12/01 14:50:19

Modified files:
src/backend/utils/adt: network.c

Log message:
netmask() and hostmask() functions should return maximum-length masklen,
per gripe from Joe Sunday.

#2Neil Conway
neilc@samurai.com
In reply to: Tom Lane (#1)
Re: pgsql-server/src/backend/utils/adt network.c

tgl@svr1.postgresql.org (Tom Lane) writes:

netmask() and hostmask() functions should return maximum-length masklen,
per gripe from Joe Sunday.

Should we add some regression tests for this behavior?

-Neil

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Neil Conway (#2)
Re: pgsql-server/src/backend/utils/adt network.c

Neil Conway <neilc@samurai.com> writes:

tgl@svr1.postgresql.org (Tom Lane) writes:

netmask() and hostmask() functions should return maximum-length masklen,
per gripe from Joe Sunday.

Should we add some regression tests for this behavior?

Don't much care --- it doesn't seem like the kind of thing that's likely
to break again, unless someone deliberately changes the behavior (which
is what happened here AFAICT; a regression test would hardly prevent it).

regards, tom lane