Participants
Bruce Momjian
Bruce Momjian
Tom Lane
Tom Lane
Attachments
Show all attachments
Thread Outline
#1Bruce MomjianBruce Momjian
Jul 08, 2004
#2Tom Lane↳Tom Laneto Bruce Momjian (#1)
Jul 10, 2004
#3Bruce Momjian↳Bruce Momjianto Tom Lane (#2)
Jul 10, 2004
#4Tom Lane↳Tom Laneto Bruce Momjian (#3)
Jul 10, 2004
#5Bruce Momjian↳Bruce Momjianto Tom Lane (#4)
Jul 10, 2004

pgsql-server: OK, another try at Darwin threads.

Started by Bruce Momjianalmost 22 years ago5 messagescomitters
Jump to latest
#1Bruce Momjian
Bruce Momjian
bruce@momjian.us

Log Message:
-----------
OK, another try at Darwin threads.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
pgsql-server/src/template:
darwin (r1.4.2.2 -> r1.4.2.3)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/template/darwin.diff?r1=1.4.2.2&r2=1.4.2.3)

#2Tom Lane
Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: pgsql-server: OK, another try at Darwin threads.

momjian@svr1.postgresql.org (Bruce Momjian) writes:

Log Message:
-----------
OK, another try at Darwin threads.

Tags:
----
REL7_4_STABLE

Seems to me that unproven fixes do not belong in stable branches.

regards, tom lane

#3Bruce Momjian
Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql-server: OK, another try at Darwin threads.

Tom Lane wrote:

momjian@svr1.postgresql.org (Bruce Momjian) writes:

Log Message:
-----------
OK, another try at Darwin threads.

Tags:
----
REL7_4_STABLE

Seems to me that unproven fixes do not belong in stable branches.

The fix was tested by several people on several versions of OSX, and it
is only enabled when compiling with thread-safety. I don't see a
problem.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#4Tom Lane
Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#3)
Re: pgsql-server: OK, another try at Darwin threads.

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Tom Lane wrote:

momjian@svr1.postgresql.org (Bruce Momjian) writes:

OK, another try at Darwin threads.

Seems to me that unproven fixes do not belong in stable branches.

The fix was tested by several people on several versions of OSX, and it
is only enabled when compiling with thread-safety. I don't see a
problem.

I found that out later on in another thread. The problem is with the
commit message, which makes it sound like this is an untested "maybe
this will work" patch ...

regards, tom lane

#5Bruce Momjian
Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#4)
Re: pgsql-server: OK, another try at Darwin threads.

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Tom Lane wrote:

momjian@svr1.postgresql.org (Bruce Momjian) writes:

OK, another try at Darwin threads.

Seems to me that unproven fixes do not belong in stable branches.

The fix was tested by several people on several versions of OSX, and it
is only enabled when compiling with thread-safety. I don't see a
problem.

I found that out later on in another thread. The problem is with the
commit message, which makes it sound like this is an untested "maybe
this will work" patch ...

Yes, the commit message was unclear.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
← Back to Topics