pgsql-server: Fix incorrect tracking of session authorization in the

Started by Tom Lanealmost 22 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Log Message:
-----------
Fix incorrect tracking of session authorization in the presence of ACLs
that contain rights granted by non-owners. Per bug report from
Nishad Prakash.

Modified Files:
--------------
pgsql-server/src/bin/pg_dump:
pg_backup_archiver.c (r1.88 -> r1.89)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/pg_dump/pg_backup_archiver.c.diff?r1=1.88&r2=1.89)

#2Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Tom Lane (#1)
Re: pgsql-server: Fix incorrect tracking of session

Is that the pg_dump half of the 'alter owner breaks non-default
privileges' bug fix?

Chris

Tom Lane wrote:

Show quoted text

Log Message:
-----------
Fix incorrect tracking of session authorization in the presence of ACLs
that contain rights granted by non-owners. Per bug report from
Nishad Prakash.

Modified Files:
--------------
pgsql-server/src/bin/pg_dump:
pg_backup_archiver.c (r1.88 -> r1.89)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/pg_dump/pg_backup_archiver.c.diff?r1=1.88&r2=1.89)

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christopher Kings-Lynne (#2)
Re: pgsql-server: Fix incorrect tracking of session

Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:

Fix incorrect tracking of session authorization in the presence of ACLs
that contain rights granted by non-owners. Per bug report from
Nishad Prakash.

Is that the pg_dump half of the 'alter owner breaks non-default
privileges' bug fix?

No, it's quite unrelated AFAICS --- the becomeUser() code was assuming
that no other part of pg_dump would emit SET SESSION AUTH commands,
when in fact the permissions-dumping code recently started doing so.

It does however occur to me that you'd better check if your recent
changes broke dumping of permissions granted by GRANT OPTION recipients.

regards, tom lane