pgsql-server: Add some strings for translation and remove some

Started by Nonamealmost 22 years ago3 messagescomitters
Jump to latest
#1Noname
dennis@svr1.postgresql.org

Log Message:
-----------
Add some strings for translation and remove some cut'n'paste
that makes it impossible to translate to other languages.

Modified Files:
--------------
pgsql-server/src/backend/libpq:
auth.c (r1.114 -> r1.115)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/libpq/auth.c.diff?r1=1.114&r2=1.115)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Noname (#1)
Re: pgsql-server: Add some strings for translation and remove some

dennis@svr1.postgresql.org (Dennis Bjorklund) writes:

Add some strings for translation and remove some cut'n'paste
that makes it impossible to translate to other languages.

The way you've done this, the string will be passed through gettext
twice at runtime (once in this routine, once inside errmsg()). That's
at best a waste of cycles and at worst a wrong answer. (Though
a match on the translated string isn't likely, it's not impossible.)

You should use gettext_noop() not gettext() to mark these strings as
translatable.

regards, tom lane

#3Dennis Bjorklund
db@zigo.dhs.org
In reply to: Tom Lane (#2)
Re: pgsql-server: Add some strings for translation and

On Wed, 4 Aug 2004, Tom Lane wrote:

The way you've done this, the string will be passed through gettext
twice at runtime (once in this routine, once inside errmsg()).

You should use gettext_noop() not gettext() to mark these strings as
translatable.

Ops. I'll take a look and fix that tonight.

--
/Dennis Bj�rklund