pgsql: New Directory

momjian@svr1.postgresql.org (Bruce Momjian) writes:

Directory /cvsroot/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1252 added to the repository

I hope this does not indicate that you are planning to commit that patch
on the day before RC1. (1) We are *far* past feature freeze. (2) The
only review I've seen of the patch so far pointed out basic typos, which
didn't exactly leave me with a warm feeling about its being
production-ready.

regards, tom lane

Tom Lane wrote:

momjian@svr1.postgresql.org (Bruce Momjian) writes:

Directory /cvsroot/pgsql/src/backend/utils/mb/conversion_procs/utf8_and_win1252 added to the repository

I hope this does not indicate that you are planning to commit that patch
on the day before RC1. (1) We are *far* past feature freeze. (2) The
only review I've seen of the patch so far pointed out basic typos, which
didn't exactly leave me with a warm feeling about its being
production-ready.

I am applying it. It was added to the queue yesterday or the day
before. I don't consider it a feature addition but rather an addition
for portability with Win32. I don't see how it affects anything unless
you use that encoding. The typos were addressed in later patches. In
fact all the versions are in the patch queue now.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Tom Lane wrote:

I hope this does not indicate that you are planning to commit that patch
on the day before RC1.

I am applying it. It was added to the queue yesterday or the day
before. I don't consider it a feature addition but rather an addition
for portability with Win32. I don't see how it affects anything unless
you use that encoding.

If it contains any core-dump-grade bugs, it can be used to cause denial
of service on any platform. And how can you possibly not consider it a
feature addition?

I'll hold still for now, but if I see so much as one compiler warning
out of it, it's going away again.

regards, tom lane

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Tom Lane wrote:

I hope this does not indicate that you are planning to commit that patch
on the day before RC1.

I am applying it. It was added to the queue yesterday or the day
before. I don't consider it a feature addition but rather an addition
for portability with Win32. I don't see how it affects anything unless
you use that encoding.

If it contains any core-dump-grade bugs, it can be used to cause denial
of service on any platform. And how can you possibly not consider it a
feature addition?

I'll hold still for now, but if I see so much as one compiler warning
out of it, it's going away again.

Well, it is of less risk than the vacuum changes you made earlier this
week that caused regression failures.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Tom Lane wrote:

I hope this does not indicate that you are planning to commit that patch
on the day before RC1.

I am applying it. It was added to the queue yesterday or the day
before. I don't consider it a feature addition but rather an addition
for portability with Win32. I don't see how it affects anything unless
you use that encoding.

If it contains any core-dump-grade bugs, it can be used to cause denial
of service on any platform. And how can you possibly not consider it a
feature addition?

I'll hold still for now, but if I see so much as one compiler warning
out of it, it's going away again.

Sorry, I mean the optimizer cost changes you made.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073