pgsql: > > 8.0beta3 has pg_autovacuum included, when I want to run this

Log Message:
-----------

8.0beta3 has pg_autovacuum included, when I want to run this as a
Windows service, it says you can use the -I and -R options.

When I do that and I specify a password with '-P'

(uppercase) then in

the registry it's saved as '-p' (lowercase) in the

service-commandline

(ImagePath).

This was fixed in v1.21 of pg_autovacuum.c, That rev is tagged for
beta3, so you should not be seeing this issue unless you actually have
an older version for some reason.

http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/p
g_autovacuum.c.diff?r1=1.20;r2=1.21;f=h

Also it removes the quotes I added and I'm not so sure it

would work

the way it's supposed to, without it.

It's not so much that it strips them (that happens automagically), more
that it doesn't re-add them when it writes the command line in the
registry. The attached patch fixes that by simply quoting all options
that may need it.

If you add DependOnService (a REG_MULTI_SZ an

array-like-thingie) and

have the name (in this case: pgsql-8.0-beta2-dev3) of a service it
depends on, it will not fail to start (it will not even try, as
PostgreSQL is not running), when PostgreSQL already failed.

Maybe it's an idea to specify it on the commandline (what

service to

depend on).

A -E <service> option is added in the attached patch.

Dave Page

Modified Files:
--------------
pgsql/contrib/pg_autovacuum:
README.pg_autovacuum (r1.10 -> r1.11)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/README.pg_autovacuum.diff?r1=1.10&amp;r2=1.11)
pg_autovacuum.c (r1.26 -> r1.27)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/pg_autovacuum.c.diff?r1=1.26&amp;r2=1.27)
pg_autovacuum.h (r1.13 -> r1.14)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_autovacuum/pg_autovacuum.h.diff?r1=1.13&amp;r2=1.14)