pgsql: Back out this because of fear of changing error strings: This

Started by Bruce Momjianover 20 years ago3 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

Log Message:
-----------
Back out this because of fear of changing error strings:

This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED
etc. match the docs, which talk about "transaction identifier" not
"gid" or "global transaction identifier".

Steve Woodcock

Modified Files:
--------------
pgsql/src/backend/access/transam:
twophase.c (r1.12 -> r1.13)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/twophase.c.diff?r1=1.12&r2=1.13)

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Bruce Momjian (#1)
Re: [COMMITTERS] pgsql: Back out this because of fear of changing error strings: This

Bruce Momjian wrote:

Back out this because of fear of changing error strings:

This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED
etc. match the docs, which talk about "transaction identifier" not
"gid" or "global transaction identifier".

I say make the change anyway. No language except Turkish is up to 100%
yet, and there's plenty of time to fix the translations. It's only
a couple of strings, right?

--
Alvaro Herrera http://www.amazon.com/gp/registry/DXLWNGRJD34
"No deja de ser humillante para una persona de ingenio saber
que no hay tonto que no le pueda ense�ar algo." (Jean B. Say)

#3Bruce Momjian
bruce@momjian.us
In reply to: Alvaro Herrera (#2)
Re: [COMMITTERS] pgsql: Back out this because of fear of changing

Alvaro Herrera wrote:

Bruce Momjian wrote:

Back out this because of fear of changing error strings:

This makes the error messages for PREPARE TRANSACTION, COMMIT PREPARED
etc. match the docs, which talk about "transaction identifier" not
"gid" or "global transaction identifier".

I say make the change anyway. No language except Turkish is up to 100%
yet, and there's plenty of time to fix the translations. It's only
a couple of strings, right?

Thanks, applied.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073