pgsql: More cleanups.

momjian@svr1.postgresql.org (Bruce Momjian) writes:

More cleanups.

Why are you cluttering the commit record with all these intermediate
states?

regards, tom lane

Tom Lane wrote:

momjian@svr1.postgresql.org (Bruce Momjian) writes:

More cleanups.

Why are you cluttering the commit record with all these intermediate
states?

I have to commit so I can see my build output that is based on CVS. I
am too lazy to build it and test the html manually.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian wrote:

I have to commit so I can see my build output that is based on CVS. I
am too lazy to build it and test the html manually.

I agree with Tom; it would be nice if you could build the docs locally,
verify that you're happy with your changes, and _then_ commit them.
(That's what I do, at any rate.)

-Neil

Neil Conway <neilc@samurai.com> writes:

Bruce Momjian wrote:

I have to commit so I can see my build output that is based on CVS. I
am too lazy to build it and test the html manually.

I agree with Tom; it would be nice if you could build the docs locally,
verify that you're happy with your changes, and _then_ commit them.
(That's what I do, at any rate.)

It's not as if Bruce hasn't got the infrastructure installed ;-).
I should think it would be *faster* to do a local build than to commit
and then wait for his background job to sync from CVS and then build.

regards, tom lane

Tom Lane wrote:

Neil Conway <neilc@samurai.com> writes:

Bruce Momjian wrote:

I have to commit so I can see my build output that is based on CVS. I
am too lazy to build it and test the html manually.

I agree with Tom; it would be nice if you could build the docs locally,
verify that you're happy with your changes, and _then_ commit them.
(That's what I do, at any rate.)

It's not as if Bruce hasn't got the infrastructure installed ;-).
I should think it would be *faster* to do a local build than to commit
and then wait for his background job to sync from CVS and then build.

OK, I modified my script so I can build it locally with one command and
put it up on the web in a temp directory so IRC folks can comment if I
have questions.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

On Sun, Mar 13, 2005 at 04:54:38PM +1100, Neil Conway wrote:

Bruce Momjian wrote:

I have to commit so I can see my build output that is based on CVS. I
am too lazy to build it and test the html manually.

I agree with Tom; it would be nice if you could build the docs locally,
verify that you're happy with your changes, and _then_ commit them.
(That's what I do, at any rate.)

FWIW, there's a "check" target in doc/src/sgml/Makefile that checks for
SGML correctness without actually building. It's been convenient to me
in the past (slow machines and all).

--
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
"Lo esencial es invisible para los ojos" (A. de Saint Ex�pery)