pgsql: Correct some code in pg_restore when reading the header of a tar

Started by Nonameabout 21 years ago1 messagescomitters
Jump to latest
#1Noname
neilc@svr1.postgresql.org

Log Message:
-----------
Correct some code in pg_restore when reading the header of a tar archive:

(1) The code doesn't initialize `sum', so the initial "does the checksum
match?" test is wrong.

(2) The loop that is intended to check for a "null block" just checks
the first byte of the tar block 512 times, rather than each of the
512 bytes one time (!), which I'm guessing was the intent.

It was only through sheer luck that this worked in the first place.

Per Coverity static analysis performed by EnterpriseDB.

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_backup_tar.c (r1.47 -> r1.48)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_tar.c.diff?r1=1.47&r2=1.48)