pgsql: Code the unknown options check without using m4 diversions.
Log Message:
-----------
Code the unknown options check without using m4 diversions. Otherwise this
code relies on the checking macro actually being called at the end, or the
automatic undiversion will produce garbage. These sort of implicit
side-effects undermine the modularity of the macros and happen to break the
ODBC driver which makes use of them.
Also put the warnings at the very end of configure, so there is an even
better chance of seeing them.
Modified Files:
--------------
pgsql:
configure (r1.515 -> r1.516)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.diff?r1=1.515&r2=1.516)
configure.in (r1.484 -> r1.485)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.in.diff?r1=1.484&r2=1.485)
pgsql/config:
general.m4 (r1.6 -> r1.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/config/general.m4.diff?r1=1.6&r2=1.7)
petere@postgresql.org (Peter Eisentraut) writes:
Code the unknown options check without using m4 diversions.
I tried this out today and noted a problem:
$ ./configure --enable-foo --with-bar --without-baz --disable-other
...
configure: WARNING: option ignored: --enable-foo
configure: WARNING: option ignored: --enable-other
configure: WARNING: option ignored: --with-bar
configure: WARNING: option ignored: --with-baz
$
Cosmetic, of course, but it really ought to report what you actually
typed...
regards, tom lane
Tom Lane wrote:
$ ./configure --enable-foo --with-bar --without-baz --disable-other
...
configure: WARNING: option ignored: --enable-foo
configure: WARNING: option ignored: --enable-other
configure: WARNING: option ignored: --with-bar
configure: WARNING: option ignored: --with-baz
Frankly, I don't think we can make that work. It would require changing
parts of Autoconf that are not set up to be changed.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/