pgsql: Some small tuptoaster improvements from Greg Stark.

Started by Tom Laneabout 19 years ago3 messagescommitters
Jump to latest
#1Tom Lane
tgl@postgresql.org

Log Message:
-----------
Some small tuptoaster improvements from Greg Stark. Avoid unnecessary
decompression of an already-compressed external value when we have to copy
it; save a few cycles when a value is too short for compression; and
annotate various lines that are currently unreachable.

Modified Files:
--------------
pgsql/src/backend/access/heap:
tuptoaster.c (r1.74 -> r1.75)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/heap/tuptoaster.c?r1=1.74&r2=1.75)

#2Greg Stark
stark@enterprisedb.com
In reply to: Tom Lane (#1)
Re: pgsql: Some small tuptoaster improvements from Greg Stark.

"Tom Lane" <tgl@postgresql.org> writes:

Log Message:
-----------
Some small tuptoaster improvements from Greg Stark. Avoid unnecessary
decompression of an already-compressed external value when we have to copy
it; save a few cycles when a value is too short for compression; and
annotate various lines that are currently unreachable.

There were some further changes you suggested involving rethinking the way the
compression strategy works. Should I put that on my todo list for early in 8.4?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Greg Stark (#2)
Re: pgsql: Some small tuptoaster improvements from Greg Stark.

Gregory Stark <stark@enterprisedb.com> writes:

There were some further changes you suggested involving rethinking the
way the compression strategy works. Should I put that on my todo list
for early in 8.4?

Sure, if you feel like working on it. (I'd hoped to get to that myself
for 8.3, but we are now well past the point where any new work should
be considered...)

regards, tom lane