pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df

Started by Nonameover 19 years ago6 messages
#1Noname
momjian@postgresql.org

Log Message:
-----------
Done:

o -Display IN, INOUT, and OUT parameters in \df

Modified Files:
--------------
pgsql/doc:
TODO (r1.1914 -> r1.1915)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/TODO.diff?r1=1.1914&r2=1.1915)
pgsql/doc/src/FAQ:
TODO.html (r1.417 -> r1.418)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/FAQ/TODO.html.diff?r1=1.417&r2=1.418)

#2David Fetter
david@fetter.org
In reply to: Noname (#1)
Re: pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df

On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:

Log Message:
-----------
Done:

o -Display IN, INOUT, and OUT parameters in \df

Oops! Should I change the patch to say IN when it's an IN parameter?
Right now, it stays silent.

Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter

Remember to vote!

#3Bruce Momjian
bruce@momjian.us
In reply to: David Fetter (#2)
Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT

David Fetter wrote:

On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:

Log Message:
-----------
Done:

o -Display IN, INOUT, and OUT parameters in \df

Oops! Should I change the patch to say IN when it's an IN parameter?
Right now, it stays silent.

[ Moved to hackers.] No idea. Comments?

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#4Andrew Dunstan
andrew@dunslane.net
In reply to: Bruce Momjian (#3)
Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT,

Bruce Momjian wrote:

David Fetter wrote:

On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:

Log Message:
-----------
Done:

o -Display IN, INOUT, and OUT parameters in \df

Oops! Should I change the patch to say IN when it's an IN parameter?
Right now, it stays silent.

[ Moved to hackers.] No idea. Comments?

Actually, I'd be inclined to put IN if there are INOUT or OUT
parameters, and nothing if they are all IN parameters, but I realise
this might seem inconsistent.

cheers

andrew

#5David Fetter
david@fetter.org
In reply to: Bruce Momjian (#3)
Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df

On Tue, Jul 18, 2006 at 06:07:01PM -0400, Bruce Momjian wrote:

David Fetter wrote:

On Tue, Jul 18, 2006 at 03:20:51PM -0300, Bruce Momjian wrote:

Log Message:
-----------
Done:

o -Display IN, INOUT, and OUT parameters in \df

Oops! Should I change the patch to say IN when it's an IN
parameter? Right now, it stays silent.

[ Moved to hackers.] No idea. Comments?

I'm thinking "no." Parameters by default are unnamed IN parameters,
so I exposed and marked things which differed from that. :)

Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778 AIM: dfetter666
Skype: davidfetter

Remember to vote!

#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: David Fetter (#5)
Re: [COMMITTERS] pgsql: Done: o -Display IN, INOUT, and OUT parameters in \df

David Fetter <david@fetter.org> writes:

On Tue, Jul 18, 2006 at 06:07:01PM -0400, Bruce Momjian wrote:

[ Moved to hackers.] No idea. Comments?

I'm thinking "no." Parameters by default are unnamed IN parameters,
so I exposed and marked things which differed from that. :)

I agree; the patch already makes \df more noisy than some would wish.

regards, tom lane