pgsql: Publish more openly the fact that autovacuum is working for

Started by Alvaro Herreraalmost 18 years ago5 messagescomitters
Jump to latest
#1Alvaro Herrera
alvherre@postgresql.org

Log Message:
-----------
Publish more openly the fact that autovacuum is working for wraparound
protection.

Simon Riggs

Modified Files:
--------------
pgsql/src/backend/postmaster:
autovacuum.c (r1.81 -> r1.82)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/autovacuum.c?r1=1.81&r2=1.82)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#1)
Re: pgsql: Publish more openly the fact that autovacuum is working for

alvherre@postgresql.org (Alvaro Herrera) writes:

Publish more openly the fact that autovacuum is working for wraparound
protection.

Now that I look more closely, there are two things I don't like about
this patch:

* it fails to ratchet up MAX_AUTOVAC_ACTIV_LEN to allow for the
additional text

* it produces something like

autovacuum: VACUUM (to prevent wraparound) foo.bar

I had thought we were generating

autovacuum: VACUUM foo.bar (to prevent wraparound)

which seems both easier to read and less likely to break any
existing code that might be trying to interpret pg_stat_activity
entries.

regards, tom lane

#3Simon Riggs
simon@2ndQuadrant.com
In reply to: Tom Lane (#2)
Re: pgsql: Publish more openly the fact that autovacuum is working for

On Mon, 2008-07-21 at 11:45 -0400, Tom Lane wrote:

alvherre@postgresql.org (Alvaro Herrera) writes:

Publish more openly the fact that autovacuum is working for wraparound
protection.

Now that I look more closely, there are two things I don't like about
this patch:

* it fails to ratchet up MAX_AUTOVAC_ACTIV_LEN to allow for the
additional text

* it produces something like

autovacuum: VACUUM (to prevent wraparound) foo.bar

I had thought we were generating

autovacuum: VACUUM foo.bar (to prevent wraparound)

which seems both easier to read and less likely to break any
existing code that might be trying to interpret pg_stat_activity
entries.

Ratcheted. Will do 8.3 change once approved.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

Attachments:

wraparound_msg.v3.CVS_HEAD.patchtext/x-patch; charset=utf-8; name=wraparound_msg.v3.CVS_HEAD.patchDownload+10-10
#4Simon Riggs
simon@2ndQuadrant.com
In reply to: Simon Riggs (#3)
Re: pgsql: Publish more openly the fact that autovacuum is working for

On Tue, 2008-07-22 at 14:19 +0100, Simon Riggs wrote:

Will do 8.3 change once approved.

Here it is.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

Attachments:

wraparound_msg.v3.REL8_3_STABLE.patchtext/x-patch; charset=utf-8; name=wraparound_msg.v3.REL8_3_STABLE.patchDownload+10-10
#5Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Simon Riggs (#4)
Re: pgsql: Publish more openly the fact that autovacuum is working for

Simon Riggs wrote:

On Tue, 2008-07-22 at 14:19 +0100, Simon Riggs wrote:

Will do 8.3 change once approved.

Here it is.

Applied, thanks.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support