pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

Started by Alvaro Herreraover 17 years ago3 messagescomitters
Jump to latest
#1Alvaro Herrera
alvherre@postgresql.org

Log Message:
-----------
pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

Modified Files:
--------------
pgsql/src/backend/utils/mb:
mbutils.c (r1.80 -> r1.81)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mb/mbutils.c?r1=1.80&r2=1.81)
pgsql/src/include/mb:
pg_wchar.h (r1.85 -> r1.86)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/mb/pg_wchar.h?r1=1.85&r2=1.86)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#1)
Re: pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

alvherre@postgresql.org (Alvaro Herrera) writes:

pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

I think the previous coding, where it was defined but empty without
ENABLE_NLS, was better. As-is, you've introduced an unnecessary reason
for NLS-compiled loadable modules to fail to work with non-NLS core
backends.

regards, tom lane

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Tom Lane (#2)
Re: pgsql: pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

Tom Lane wrote:

alvherre@postgresql.org (Alvaro Herrera) writes:

pg_bind_textdomain_codeset must exist only on ENABLE_NLS.

I think the previous coding, where it was defined but empty without
ENABLE_NLS, was better. As-is, you've introduced an unnecessary reason
for NLS-compiled loadable modules to fail to work with non-NLS core
backends.

Uh-huh, interesting. Fixed (I hope).

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.