pgsql: Make directory name comparisons on Win32 case insensitive.

Started by Magnus Haganderover 17 years ago3 messagescomitters
Jump to latest
#1Magnus Hagander
magnus@hagander.net

Log Message:
-----------
Make directory name comparisons on Win32 case insensitive.

This method will not catch all different ways since the locale
handling in NTFS doesn't provide an easy way to do that, but it
will hopefully solve the most common cases causing startup
problems when the backend is found in the system PATH.

Attempts to fix bug #4694.

Modified Files:
--------------
pgsql/src/port:
path.c (r1.76 -> r1.77)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/path.c?r1=1.76&r2=1.77)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Hagander (#1)
Re: pgsql: Make directory name comparisons on Win32 case insensitive.

mha@postgresql.org (Magnus Hagander) writes:

Log Message:
-----------
Make directory name comparisons on Win32 case insensitive.

Hmm, for consistency you really should be doing
pg_tolower((unsigned char) *foo)
here.

It's possible that the cast is not necessary on Windows, but
even so code consistency is a good thing.

regards, tom lane

#3Magnus Hagander
magnus@hagander.net
In reply to: Tom Lane (#2)
Re: pgsql: Make directory name comparisons on Win32 case insensitive.

Tom Lane wrote:

mha@postgresql.org (Magnus Hagander) writes:

Log Message:
-----------
Make directory name comparisons on Win32 case insensitive.

Hmm, for consistency you really should be doing
pg_tolower((unsigned char) *foo)
here.

It's possible that the cast is not necessary on Windows, but
even so code consistency is a good thing.

I see you've fixed this, thanks.

//Magnus