pgsql: Replace the array-style TupleTable data structure with a simple

Started by Tom Lanealmost 17 years ago2 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Log Message:
-----------
Replace the array-style TupleTable data structure with a simple List of
TupleTableSlot nodes. This eliminates the need to count in advance
how many Slots will be needed, which seems more than worth the small
increase in the amount of palloc traffic during executor startup.

The ExecCountSlots infrastructure is now all dead code, but I'll remove it
in a separate commit for clarity.

Per a comment from Robert Haas.

Modified Files:
--------------
pgsql/src/backend/executor:
execMain.c (r1.328 -> r1.329)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c?r1=1.328&r2=1.329)
execTuples.c (r1.109 -> r1.110)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execTuples.c?r1=1.109&r2=1.110)
execUtils.c (r1.161 -> r1.162)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execUtils.c?r1=1.161&r2=1.162)
nodeSubplan.c (r1.99 -> r1.100)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSubplan.c?r1=1.99&r2=1.100)
pgsql/src/include/executor:
tuptable.h (r1.42 -> r1.43)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/executor/tuptable.h?r1=1.42&r2=1.43)
pgsql/src/include/nodes:
execnodes.h (r1.207 -> r1.208)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/execnodes.h?r1=1.207&r2=1.208)

#2Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#1)
Re: pgsql: Replace the array-style TupleTable data structure with a simple

On Sun, Sep 27, 2009 at 4:09 PM, Tom Lane <tgl@postgresql.org> wrote:

Log Message:
-----------
Replace the array-style TupleTable data structure with a simple List of
TupleTableSlot nodes.  This eliminates the need to count in advance
how many Slots will be needed, which seems more than worth the small
increase in the amount of palloc traffic during executor startup.

The ExecCountSlots infrastructure is now all dead code, but I'll remove it
in a separate commit for clarity.

Per a comment from Robert Haas.

Wow, nice. That saved a bucketload of code.

...Robert