pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0

Started by Bruce Momjianover 16 years ago4 messagescomitters
Jump to latest
#1Bruce Momjian
bruce@momjian.us

Log Message:
-----------
Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 binary
upgrades.

Modified Files:
--------------
pgsql/src/backend/utils/time:
tqual.c (r1.116 -> r1.117)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/time/tqual.c?r1=1.116&r2=1.117)
pgsql/src/include/access:
htup.h (r1.111 -> r1.112)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/htup.h?r1=1.111&r2=1.112)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0

momjian@postgresql.org (Bruce Momjian) writes:

Log Message:
-----------
Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 binary
upgrades.

This seems fairly redundant with the comments that were already there.

regards, tom lane

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0

Tom Lane wrote:

momjian@postgresql.org (Bruce Momjian) writes:

Log Message:
-----------
Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 binary
upgrades.

This seems fairly redundant with the comments that were already there.

The comment was at the top of SetHintBits(), which I didn't think would
be seen near the many other references to HEAP_MOVED_* father down
in the file.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#4Bruce Momjian
bruce@momjian.us
In reply to: Bruce Momjian (#3)
Re: pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0

bruce wrote:

Tom Lane wrote:

momjian@postgresql.org (Bruce Momjian) writes:

Log Message:
-----------
Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 binary
upgrades.

This seems fairly redundant with the comments that were already there.

The comment was at the top of SetHintBits(), which I didn't think would
be seen near the many other references to HEAP_MOVED_* father down
in the file.

The only other thing we could do is to mention the HEAP_MOVED_* only at
the top of the file, but I have tried to label binary upgrade code
clearly so we know why it is there and when it can be removed.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +