gratuituous string difference

Started by Alvaro Herreraover 19 years ago3 messageshackers
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

This patch fixes a gratuituous string difference. Barring objections
I'll apply shortly.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachments:

typecmds.patchtext/plain; charset=us-asciiDownload+2-2
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#1)
Re: gratuituous string difference

Alvaro Herrera <alvherre@commandprompt.com> writes:

This patch fixes a gratuituous string difference. Barring objections
I'll apply shortly.

I object. We do not quote the output of format_type_be() ... look at
its code to see why not.

regards, tom lane

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Tom Lane (#2)
Re: gratuituous string difference

Tom Lane wrote:

Alvaro Herrera <alvherre@commandprompt.com> writes:

This patch fixes a gratuituous string difference. Barring objections
I'll apply shortly.

I object. We do not quote the output of format_type_be() ... look at
its code to see why not.

Oh, I see -- it may add double quotes on its own in certain cases, while
the other string gets the input from TypeNameToString which never does.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support