pgsql: Rewrite LIKE's %-followed-by-_ optimization so it really works

Started by Tom Laneabout 16 years ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Log Message:
-----------
Rewrite LIKE's %-followed-by-_ optimization so it really works (this time
for sure ;-)). It now also optimizes more cases, such as %_%_. Improve
comments too. Per bug #5478.

In passing, also rename the TCHAR macro to GETCHAR, because pgindent is
messing with the formatting of the former (apparently it now thinks TCHAR
is a typedef name).

Back-patch to 8.3, where the bug was introduced.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
pgsql/src/backend/utils/adt:
like_match.c (r1.20.2.3 -> r1.20.2.4)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/like_match.c?r1=1.20.2.3&r2=1.20.2.4)
pgsql/src/test/regress/expected:
strings.out (r1.33.2.1 -> r1.33.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/strings.out?r1=1.33.2.1&r2=1.33.2.2)
pgsql/src/test/regress/sql:
strings.sql (r1.22.2.1 -> r1.22.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/strings.sql?r1=1.22.2.1&r2=1.22.2.2)