pgsql: Rearrange dblink's dblink_build_sql_insert() and related routines

Started by Tom Laneabout 16 years ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Log Message:
-----------
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
lock the target relation just once per SQL function call. The original coding
obtained and released lock several times per call. Aside from saving a
not-insignificant number of cycles, this eliminates possible race conditions
if someone tries to modify the relation's schema concurrently. Also
centralize locking and permission-checking logic.

Problem noted while investigating a trouble report from Robert Voinea --- his
problem is still to be fixed, though.

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
pgsql/contrib/dblink:
dblink.c (r1.82.2.5 -> r1.82.2.6)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/dblink/dblink.c?r1=1.82.2.5&r2=1.82.2.6)