pgsql: Improve pg_dump's checkSeek() function to verify the functioning

Started by Tom Laneabout 16 years ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Log Message:
-----------
Improve pg_dump's checkSeek() function to verify the functioning of ftello
as well as fseeko, and to not assume that fseeko(fp, 0, SEEK_CUR) proves
anything. Also improve some related comments. Per my observation that
the SEEK_CUR test didn't actually work on some platforms, and subsequent
discussion with Robert Haas.

Back-patch to 8.4. In earlier releases it's not that important whether
we get the hasSeek test right, but with parallel restore it matters.

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_backup_archiver.c (r1.172.2.1 -> r1.172.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_archiver.c?r1=1.172.2.1&r2=1.172.2.2)
pg_backup_custom.c (r1.42.2.1 -> r1.42.2.2)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_custom.c?r1=1.42.2.1&r2=1.42.2.2)