Recent ecpg patch...
.. appears to have killed win32. It did kill my manual MSVC builds, but
it also seems to have killed win32 buildfarm members yak and snake:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=yak&dt=2007-01-11%2020:32:11
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=snake&dt=2007-01-11%2018:30:01
(same error on mingw and msvc)
//Magnus
On Thu, Jan 11, 2007 at 09:59:14PM +0100, Magnus Hagander wrote:
.. appears to have killed win32. It did kill my manual MSVC builds, but
it also seems to have killed win32 buildfarm members yak and snake:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=yak&dt=2007-01-11%2020:32:11
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=snake&dt=2007-01-11%2018:30:01
(same error on mingw and msvc)
ecpg_internal_regression_mode has to be declared at least in one file without
the "extern" keyword.
With the attached patch I get a clean build again with MSVC.
Joachim
Attachments:
ecpg.difftext/x-diff; NAME=ecpg.diff; charset=us-asciiDownload
? .deps
? libecpg.so.5.3
Index: misc.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/interfaces/ecpg/ecpglib/misc.c,v
retrieving revision 1.33
diff -u -r1.33 misc.c
--- misc.c 11 Jan 2007 15:47:33 -0000 1.33
+++ misc.c 11 Jan 2007 23:25:29 -0000
@@ -28,7 +28,7 @@
#endif
#endif
-extern int ecpg_internal_regression_mode;
+int ecpg_internal_regression_mode;
static struct sqlca_t sqlca_init =
{
Joachim Wieland wrote:
On Thu, Jan 11, 2007 at 09:59:14PM +0100, Magnus Hagander wrote:
.. appears to have killed win32. It did kill my manual MSVC builds, but
it also seems to have killed win32 buildfarm members yak and snake:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=yak&dt=2007-01-11%2020:32:11
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=snake&dt=2007-01-11%2018:30:01(same error on mingw and msvc)
ecpg_internal_regression_mode has to be declared at least in one file without
the "extern" keyword.With the attached patch I get a clean build again with MSVC.
In case nobody has confirmed that yet (I may have missed a msg or two),
with whatever got committed to cvs eventually, it builds fine on MSVC now.
//Magnus