pgsql: Remove optreset from src/port/ implementations of getopt and get

Started by Tom Laneover 15 years ago1 messagescomitters

tgl@sss.pgh.pa.us

over 15 years ago

Remove optreset from src/port/ implementations of getopt and getopt_long.

We don't actually need optreset, because we can easily fix the code to
ensure that it's cleanly restartable after having completed a scan over the
argv array; which is the only case we need to restart in. Getting rid of
it avoids a class of interactions with the system libraries and allows
reversion of my change of yesterday in postmaster.c and postgres.c.

Back-patch to 8.4. Before that the getopt code was a bit different anyway.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=77451164e9936ac70ffdaca7e7f2c5eb7e148850

Modified Files
--------------
src/backend/postmaster/postmaster.c | 5 ++---
src/backend/tcop/postgres.c | 5 ++---
src/include/getopt_long.h | 1 -
src/port/getopt.c | 20 +++++++++++---------
src/port/getopt_long.c | 20 +++++++++++---------
5 files changed, 26 insertions(+), 25 deletions(-)