UUID patch broke win32

Started by Magnus Haganderabout 19 years ago2 messageshackers
Jump to latest
#1Magnus Hagander
magnus@hagander.net

Seems the UUID patch broke Windows builds.
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=snake&dt=2007-01-28%2018:30:01

uuid_t is defined to UUID in the win32 platform SDK header files. I
would suggest we use pguuid_t or something like that instead.

//Magnus

#2Neil Conway
neilc@samurai.com
In reply to: Magnus Hagander (#1)
Re: UUID patch broke win32

On Sun, 2007-01-28 at 20:47 +0100, Magnus Hagander wrote:

uuid_t is defined to UUID in the win32 platform SDK header files. I
would suggest we use pguuid_t or something like that instead.

We could possibly try to workaround it by #undef'ing any existing uuid_t
definitions before we supply our own, but per out-of-band discussion
with Magnus, it seems safer to just use a different type name
altogether. Attached is a patch that renames uuid_t to pg_uuid_t (and
makes some other minor cleanup of uuid.c), which I'll apply shortly.

-Neil

Attachments:

rename_uuid_t-1.patchtext/x-patch; charset=us-ascii; name=rename_uuid_t-1.patchDownload+92-91