pgsql: Clarify error message when attempting to create index on foreign

Started by Magnus Haganderover 15 years ago3 messagescomitters
Jump to latest
#1Magnus Hagander
magnus@hagander.net

Clarify error message when attempting to create index on foreign table

Instead of just saying "is not a table", specifically state that
indexes aren't supported on *foreign* tables.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d76a149c955a6525c8d42425c57e32d74d2c2eed

Modified Files
--------------
src/backend/commands/indexcmds.c | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Magnus Hagander (#1)
Re: pgsql: Clarify error message when attempting to create index on foreign

Excerpts from Magnus Hagander's message of jue may 05 16:48:07 -0300 2011:

Clarify error message when attempting to create index on foreign table

Instead of just saying "is not a table", specifically state that
indexes aren't supported on *foreign* tables.

Buildfarm broke ... do you need to update regression tests' expected
files?

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#3Magnus Hagander
magnus@hagander.net
In reply to: Alvaro Herrera (#2)
Re: pgsql: Clarify error message when attempting to create index on foreign

On Thu, May 5, 2011 at 22:20, Alvaro Herrera <alvherre@commandprompt.com> wrote:

Excerpts from Magnus Hagander's message of jue may 05 16:48:07 -0300 2011:

Clarify error message when attempting to create index on foreign table

Instead of just saying "is not a table", specifically state that
indexes aren't supported on *foreign* tables.

Buildfarm broke ... do you need to update regression tests' expected
files?

gah, I guess no patch is small enough that I shouldn't run through the
regression tests. Pfft .Sorry about that, will fix. Thanks for
pointing it out.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/