pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

Started by Simon Riggsabout 15 years ago6 messagescomitters
Jump to latest
#1Simon Riggs
simon@2ndQuadrant.com

Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
Locks on inheritance parent remain at lower level, as they were before.
Remove entry from 9.1 release notes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2c3d9db56d5d49bdc777b174982251c01348e3d8

Modified Files
--------------
doc/src/sgml/release-9.1.sgml | 17 +----------------
src/backend/commands/tablecmds.c | 28 ++++++++++++++++++++++++++++
2 files changed, 29 insertions(+), 16 deletions(-)

#2Simon Riggs
simon@2ndQuadrant.com
In reply to: Simon Riggs (#1)
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
Locks on inheritance parent remain at lower level, as they were before.
Remove entry from 9.1 release notes.

This commit caused pgbuildfarm failures on 15 machines this morning.
Later commit fixes this, I forgot that the lock level is specifically
mentioned in regression test results.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

#3Robert Haas
robertmhaas@gmail.com
In reply to: Simon Riggs (#2)
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
Locks on inheritance parent remain at lower level, as they were before.
Remove entry from 9.1 release notes.

This commit caused pgbuildfarm failures on 15 machines this morning.
Later commit fixes this, I forgot that the lock level is specifically
mentioned in regression test results.

I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite().

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#4Simon Riggs
simon@2ndQuadrant.com
In reply to: Robert Haas (#3)
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

On Tue, Jul 5, 2011 at 2:46 PM, Robert Haas <robertmhaas@gmail.com> wrote:

On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
Locks on inheritance parent remain at lower level, as they were before.
Remove entry from 9.1 release notes.

This commit caused pgbuildfarm failures on 15 machines this morning.
Later commit fixes this, I forgot that the lock level is specifically
mentioned in regression test results.

I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite().

Thanks. Will address.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Robert Haas (#3)
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

Robert Haas <robertmhaas@gmail.com> writes:

On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
Locks on inheritance parent remain at lower level, as they were before.
Remove entry from 9.1 release notes.

I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite().

I took care of this.

regards, tom lane

#6Simon Riggs
simon@2ndQuadrant.com
In reply to: Tom Lane (#5)
Re: pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

On Thu, Jul 7, 2011 at 6:17 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs <simon@2ndquadrant.com> wrote:

Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases.
Locks on inheritance parent remain at lower level, as they were before.
Remove entry from 9.1 release notes.

I believe you need a similar fix in CreateTrigger() and DefineQueryRewrite().

I took care of this.

Thanks.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services