pgsql: Add C comment about why we send cache invalidation messages for

Started by Bruce Momjianalmost 15 years ago5 messagescomitters
Jump to latest
#1Bruce Momjian
bruce@momjian.us

Add C comment about why we send cache invalidation messages for
session-local objects.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f458c90bff45ecae91fb55ef2b938af37d977af3

Modified Files
--------------
src/backend/utils/cache/inval.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: pgsql: Add C comment about why we send cache invalidation messages for

Bruce Momjian <bruce@momjian.us> writes:

Add C comment about why we send cache invalidation messages for
session-local objects.

This comment seems inaccurate and bizarrely placed. What question
were you trying to answer?

regards, tom lane

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql: Add C comment about why we send cache invalidation messages for

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

Add C comment about why we send cache invalidation messages for
session-local objects.

This comment seems inaccurate and bizarrely placed. What question
were you trying to answer?

It was in response to my email where I asked why we are sending cache
invalidation messages for temporary tables that can't be seen by any
other backends:

http://archives.postgresql.org/pgsql-hackers/2011-03/msg00844.php

i.e. why are we generating unnecessary invalidation traffic. Is there a
better place for the comment?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#3)
Re: pgsql: Add C comment about why we send cache invalidation messages for

Bruce Momjian <bruce@momjian.us> writes:

Tom Lane wrote:

This comment seems inaccurate and bizarrely placed. What question
were you trying to answer?

It was in response to my email where I asked why we are sending cache
invalidation messages for temporary tables that can't be seen by any
other backends:
http://archives.postgresql.org/pgsql-hackers/2011-03/msg00844.php

Oh. OK, I cleaned it up a bit.

regards, tom lane

#5Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#4)
Re: pgsql: Add C comment about why we send cache invalidation messages for

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

Tom Lane wrote:

This comment seems inaccurate and bizarrely placed. What question
were you trying to answer?

It was in response to my email where I asked why we are sending cache
invalidation messages for temporary tables that can't be seen by any
other backends:
http://archives.postgresql.org/pgsql-hackers/2011-03/msg00844.php

Oh. OK, I cleaned it up a bit.

Thanks. Good to have it documented.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +