pgsql: Eliminate memory leaks in plperl's spi_prepare() function.

Eliminate memory leaks in plperl's spi_prepare() function.

Careless use of TopMemoryContext for I/O function data meant that repeated
use of spi_prepare and spi_freeplan would leak memory at the session level,
as per report from Christian Schröder. In addition, spi_prepare
leaked a lot of transient data within the current plperl function's SPI
Proc context, which would be a problem for repeated use of spi_prepare
within a single plperl function call; and it wasn't terribly careful
about releasing permanent allocations in event of an error, either.

In passing, clean up some copy-and-pasteos in query-lookup error messages.

Alex Hunsaker and Tom Lane

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/18c6dd8b6d613c1b5c5de7fb795d296392c15a74

Modified Files
--------------
src/pl/plperl/plperl.c | 116 ++++++++++++++++++++++++++++++------------------
1 files changed, 72 insertions(+), 44 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers