pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

Started by Robert Haasabout 13 years ago6 messagescomitters

Jump to latest

Robert Haas

robertmhaas@gmail.com

about 13 years ago

Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

Andres Freund

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/17fa4c321ccf9693de406faffe6b235e949aa25f

Modified Files
--------------
src/backend/commands/vacuumlazy.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Andres Freund

andres@anarazel.de

over 12 years ago

In reply to: Robert Haas (#1)

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

Hi,

On 2013-06-06 14:22:12 +0000, Robert Haas wrote:

Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

This didn't make it to the release notes for 9.2.5. Since there have
been several people asking for it since, can we maybe add it
retroactively?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Bruce Momjian

bruce@momjian.us

over 12 years ago

In reply to: Andres Freund (#2)

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:

Hi,

On 2013-06-06 14:22:12 +0000, Robert Haas wrote:

Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

This didn't make it to the release notes for 9.2.5. Since there have
been several people asking for it since, can we maybe add it
retroactively?

OK, what text would I use? This?

* Prevent unitialized heap pages from causing standby replay
failures

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Andres Freund

andres@anarazel.de

over 12 years ago

In reply to: Bruce Momjian (#3)

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote:

On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:

Hi,

On 2013-06-06 14:22:12 +0000, Robert Haas wrote:

Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

This didn't make it to the release notes for 9.2.5. Since there have
been several people asking for it since, can we maybe add it
retroactively?

OK, what text would I use? This?

* Prevent unitialized heap pages from causing standby replay
failures

Maybe:

* Prevent errors in WAL replay due to references to unitilizated empty
pages in vacuum.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Stefan Kaltenbrunner

stefan@kaltenbrunner.cc

over 12 years ago

In reply to: Andres Freund (#4)

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

On 11/18/2013 10:40 PM, Andres Freund wrote:

On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote:

On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:

Hi,

On 2013-06-06 14:22:12 +0000, Robert Haas wrote:

Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

This didn't make it to the release notes for 9.2.5. Since there have
been several people asking for it since, can we maybe add it
retroactively?

OK, what text would I use? This?

* Prevent unitialized heap pages from causing standby replay
failures

Maybe:

* Prevent errors in WAL replay due to references to unitilizated empty
pages in vacuum.

s/unitilizated/uninitialized I guess - also not sure the "in vacuum"
makes the actual issue very clear.

Stefan

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Bruce Momjian

bruce@momjian.us

over 12 years ago

In reply to: Stefan Kaltenbrunner (#5)

Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

On Fri, Nov 22, 2013 at 08:04:07PM +0100, Stefan Kaltenbrunner wrote:

On 11/18/2013 10:40 PM, Andres Freund wrote:

On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote:

On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote:

Hi,

On 2013-06-06 14:22:12 +0000, Robert Haas wrote:

Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page.

This didn't make it to the release notes for 9.2.5. Since there have
been several people asking for it since, can we maybe add it
retroactively?

OK, what text would I use? This?

* Prevent unitialized heap pages from causing standby replay
failures

Maybe:

* Prevent errors in WAL replay due to references to unitilizated empty
pages in vacuum.

s/unitilizated/uninitialized I guess - also not sure the "in vacuum"
makes the actual issue very clear.

Applied and backpatched through 9.2. Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers