pgsql: Fix some more bugs in signal handlers and process shutdown logic

Started by Tom Laneover 12 years ago1 messagescomitters

tgl@sss.pgh.pa.us

over 12 years ago

Fix some more bugs in signal handlers and process shutdown logic.

WalSndKill was doing things exactly backwards: it should first clear
MyWalSnd (to stop signal handlers from touching MyWalSnd->latch),
then disown the latch, and only then mark the WalSnd struct unused by
clearing its pid field.

Also, WalRcvSigUsr1Handler and worker_spi_sighup failed to preserve
errno, which is surely a requirement for any signal handler.

Per discussion of recent buildfarm failures. Back-patch as far
as the relevant code exists.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/81b116d987a779de7c97f5fd415a7c8348b9afff

Modified Files
--------------
src/backend/replication/walsender.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers