pgsql: Remove rm_safe_restartpoint machinery.

Started by Heikki Linnakangasover 12 years ago3 messagescomitters
Jump to latest
#1Heikki Linnakangas
heikki.linnakangas@enterprisedb.com

Remove rm_safe_restartpoint machinery.

It is no longer used, none of the resource managers have multi-record
actions that would make it unsafe to perform a restartpoint.

Also don't allow rm_cleanup to write WAL records, it's also no longer
required. Move the call to rm_cleanup routines to make it more symmetric
with rm_startup.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/59a5ab3f426e74e3f901dc2cf533726bcea08ed2

Modified Files
--------------
src/backend/access/transam/rmgr.c | 4 +--
src/backend/access/transam/xlog.c | 50 +++++-------------------------------
src/include/access/rmgr.h | 2 +-
src/include/access/rmgrlist.h | 36 +++++++++++++-------------
src/include/access/xlog_internal.h | 1 -
5 files changed, 28 insertions(+), 65 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Andres Freund
andres@anarazel.de
In reply to: Heikki Linnakangas (#1)
Re: pgsql: Remove rm_safe_restartpoint machinery.

Hi,

On 2014-03-18 20:11:37 +0000, Heikki Linnakangas wrote:

Remove rm_safe_restartpoint machinery.

Neato, but I think you forgot to update contrib/pg_xlogdump.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Andres Freund (#2)
Re: pgsql: Remove rm_safe_restartpoint machinery.

On 03/18/2014 10:19 PM, Andres Freund wrote:

On 2014-03-18 20:11:37 +0000, Heikki Linnakangas wrote:

Remove rm_safe_restartpoint machinery.

Neato, but I think you forgot to update contrib/pg_xlogdump.

Oops, indeed. Fixed, thanks!

- Heikki

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers