pgsql: Move view reloptions into their own varlena struct
Move view reloptions into their own varlena struct
Per discussion after a gripe from me in
/messages/by-id/20140611194633.GH18688@eldon.alvh.no-ip.org
Jaime Casanova
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/346d7be184a617ca9f64bdf5c25fd6bcd5231293
Modified Files
--------------
src/backend/access/common/reloptions.c | 42 +++++++++++++++++++++-----
src/backend/commands/tablecmds.c | 9 ++++--
src/include/access/reloptions.h | 1 +
src/include/utils/rel.h | 52 ++++++++++++++++++++------------
src/tools/pgindent/typedefs.list | 1 +
5 files changed, 76 insertions(+), 29 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
Move view reloptions into their own varlena struct
Shouldn't this have included a catversion bump?
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Tom Lane wrote:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
Move view reloptions into their own varlena struct
Shouldn't this have included a catversion bump?
Hmm ... I'm not sure I see a reason for that. Parsed reloptions are not
stored on disk anywhere, and this patch doesn't change how they are
represented in the reloptions column.
--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
Tom Lane wrote:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
Move view reloptions into their own varlena struct
Shouldn't this have included a catversion bump?
Hmm ... I'm not sure I see a reason for that. Parsed reloptions are not
stored on disk anywhere, and this patch doesn't change how they are
represented in the reloptions column.
Oh, okay, no need then. I thought this was changing the on-disk
representation.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers