pgsql: Add missing index terms for replication commands in the document

Started by Fujii Masaoalmost 12 years ago5 messagescomitters
Jump to latest
#1Fujii Masao
masao.fujii@gmail.com

Add missing index terms for replication commands in the document.

Previously only CREATE_REPLICATION_SLOT was exposed as an index term.
That's odd and there is no reason not to add index terms for other
replication commands.

Back-patch to 9.4.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/3b2f4aa0f0fe23b0cac753f91833df353994d298

Modified Files
--------------
doc/src/sgml/protocol.sgml | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Michael Paquier
michael@paquier.xyz
In reply to: Fujii Masao (#1)
Re: pgsql: Add missing index terms for replication commands in the document

On Mon, Aug 18, 2014 at 11:38 AM, Fujii Masao <fujii@postgresql.org> wrote:

Add missing index terms for replication commands in the document.

Previously only CREATE_REPLICATION_SLOT was exposed as an index term.
That's odd and there is no reason not to add index terms for other
replication commands.

Wouldn't it be worth back-patching more a lighter patch for
BASE_BACKUP, START_REPLICATION and TIMELINE_HISTORY and
IDENTIFY_SYSTEM?
Regards,
--
Michael

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Michael Paquier (#2)
Re: pgsql: Add missing index terms for replication commands in the document

On Mon, Aug 18, 2014 at 11:48 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:

On Mon, Aug 18, 2014 at 11:38 AM, Fujii Masao <fujii@postgresql.org> wrote:

Add missing index terms for replication commands in the document.

Previously only CREATE_REPLICATION_SLOT was exposed as an index term.
That's odd and there is no reason not to add index terms for other
replication commands.

Wouldn't it be worth back-patching more a lighter patch for
BASE_BACKUP, START_REPLICATION and TIMELINE_HISTORY and
IDENTIFY_SYSTEM?

I don't feel inclined to do that because it's not a bug fix.
I have no objection if many people want that, though...

Regards,

--
Fujii Masao

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#4Bruce Momjian
bruce@momjian.us
In reply to: Fujii Masao (#3)
Re: pgsql: Add missing index terms for replication commands in the document

On Mon, Aug 18, 2014 at 12:28:52PM +0900, Fujii Masao wrote:

On Mon, Aug 18, 2014 at 11:48 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:

On Mon, Aug 18, 2014 at 11:38 AM, Fujii Masao <fujii@postgresql.org> wrote:

Add missing index terms for replication commands in the document.

Previously only CREATE_REPLICATION_SLOT was exposed as an index term.
That's odd and there is no reason not to add index terms for other
replication commands.

Wouldn't it be worth back-patching more a lighter patch for
BASE_BACKUP, START_REPLICATION and TIMELINE_HISTORY and
IDENTIFY_SYSTEM?

I don't feel inclined to do that because it's not a bug fix.
I have no objection if many people want that, though...

Agreed. I often avoid backpatching as it requires those who translate
the docs to make more adjustments for minor releases.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#5Michael Paquier
michael@paquier.xyz
In reply to: Bruce Momjian (#4)
Re: pgsql: Add missing index terms for replication commands in the document

On Thu, Aug 21, 2014 at 8:33 AM, Bruce Momjian <bruce@momjian.us> wrote:

On Mon, Aug 18, 2014 at 12:28:52PM +0900, Fujii Masao wrote:

I don't feel inclined to do that because it's not a bug fix.
I have no objection if many people want that, though...

Agreed. I often avoid backpatching as it requires those who translate
the docs to make more adjustments for minor releases.

I see, thanks! This is a valid concern. I'll be more careful in the future.
Regards,
--
Michael

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers